Skip to content

Fix macOS-arm64 architecture value from lowercase to uppercase in CI #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fix macOS-arm64 architecture value from lowercase to uppercase in CI #1759

merged 1 commit into from
Jun 17, 2024

Conversation

@dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jun 17, 2024 •
edited
Loading

Content

This PR includes a fix related to the merge of the PR #1752.
Error: https://github.com/input-output-hk/mithril/actions/runs/9548794327/job/26317878165#step:8:10

Rename /package-macOS-arm64 to /package-macOS-ARM64 to match the actions/upload-artifact@v4 nomenclature.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Relates to #1751

@dlachaume dlachaume self-assigned this Jun 17, 2024
@github-actions
Copy link

github-actions bot commented Jun 17, 2024

Test Results

    4 files  ±0     51 suites  ±0   8m 46s ⏱️ +26s
1 069 tests ±0  1 069 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 217 runs  ±0  1 217 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5f6c1f2. ± Comparison against base commit 0d4e362.

@dlachaume dlachaume temporarily deployed to testing-preview June 17, 2024 14:26 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet June 17, 2024 14:26 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume marked this pull request as ready for review June 17, 2024 14:29
@dlachaume dlachaume requested review from Alenar and sfauvel June 17, 2024 14:29
@dlachaume dlachaume merged commit d7141c0 into main Jun 17, 2024
@dlachaume dlachaume deleted the dlachaume/fix-ci-download-artifact-runner branch June 17, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@dlachaume dlachaume

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dlachaume @Alenar @jpraynaud