Skip to content

Use macOS-arm64 runner in CI #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 17, 2024
Merged

Use macOS-arm64 runner in CI #1752

merged 4 commits into from
Jun 17, 2024

Conversation

@dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jun 14, 2024 •
edited
Loading

Content

This PR adds a new macOS-arm64 runner used for the following steps in the CI:

  • build step for mithril-client binary, mithril-client and mithril-stm librairies
  • test step for mithril-client binary and library
  • packaging the pre-built binaries in the releases
  • Mithril Client multi-platform test manual workflow

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1751

@dlachaume dlachaume self-assigned this Jun 14, 2024
@github-actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

Test Results

    4 files  + 1     51 suites  +7   8m 35s ⏱️ -7s
1 069 tests ± 0  1 069 ✅ ± 0  0 💤 ±0  0 ❌ ±0 
1 217 runs  +50  1 217 ✅ +50  0 💤 ±0  0 ❌ ±0 

Results for commit 4b9473e. ± Comparison against base commit 4f5b1c5.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume marked this pull request as ready for review June 14, 2024 16:24
@dlachaume dlachaume temporarily deployed to testing-preview June 14, 2024 16:25 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet June 14, 2024 16:25 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume force-pushed the dlachaume/1751/add-macos-arm64-in-ci branch from 10ae4ec to 971d54e Compare June 17, 2024 10:45
@dlachaume dlachaume temporarily deployed to testing-preview June 17, 2024 11:03 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet June 17, 2024 11:03 — with GitHub Actions Inactive
dlachaume added 3 commits June 17, 2024 15:02
@dlachaume
Add macOS-arm64 runners in build and test steps of the CI
7316585 
Handle "error: externally-managed-environment" on macOS arm64 runners
when running `pip3 install toml` by adding a new step "Set up Python"
@dlachaume
Add macOS-arm64 version of the pre-built binaries in the releases
d52e6bb
@dlachaume
Add test of macOS-arm64 binaries in the Mithril Client multi-platfo…
cf70bbd 
…rm test manual workflow
@dlachaume dlachaume force-pushed the dlachaume/1751/add-macos-arm64-in-ci branch from 971d54e to 04c54c8 Compare June 17, 2024 13:19
@dlachaume dlachaume temporarily deployed to testing-preview June 17, 2024 13:26 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet June 17, 2024 13:26 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/1751/add-macos-arm64-in-ci branch from 04c54c8 to 4b9473e Compare June 17, 2024 13:32
@dlachaume dlachaume temporarily deployed to testing-preview June 17, 2024 13:39 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet June 17, 2024 13:39 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 0d4e362 into main Jun 17, 2024
@dlachaume dlachaume deleted the dlachaume/1751/add-macos-arm64-in-ci branch June 17, 2024 13:41
@dlachaume dlachaume mentioned this pull request Jun 17, 2024
Merged
12 tasks
@dlachaume dlachaume linked an issue Jun 17, 2024 that may be closed by this pull request
Build, test and package arm64 binaries in CI #1751
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@dlachaume dlachaume

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build, test and package arm64 binaries in CI

4 participants

@dlachaume @Alenar @jpraynaud