chore: apply PR reviews suggestions

- fix/enhance some doc comments and logs
- use u64 everywhere for offset configuration and parsing
- `expand_epoch`:
  - use const value from `"latest".len()` instead of `7`
  - tests: add decimal cases

Author: Alenar

mithril-aggregator/src/database/repository/signed_entity_store.rs

@@ -44,7 +44,7 @@ pub trait SignedEntityStorer: Sync + Send {
         total: usize,
     ) -> StdResult<Vec<SignedEntityRecord>>;
 
-    /// Get Cardano database signed entities by epoch
+    /// Get signed entities by signed entity type and epoch
     async fn get_last_signed_entities_by_type_and_epoch(
         &self,
         signed_entity_type_id: &SignedEntityTypeDiscriminants,

mithril-aggregator/src/http_server/routes/artifact_routes/cardano_database.rs

@@ -23,7 +23,7 @@ fn artifact_cardano_database_list(
         .and_then(handlers::list_artifacts)
 }
 
-/// GET /artifact/cardano-database/epoch/:epoch{-offset}
+/// GET /artifact/cardano-database/epoch/:epoch
 fn artifact_cardano_database_list_by_epoch(
     router_state: &RouterState,
 ) -> impl Filter<Extract = (impl warp::Reply + use<>,), Error = warp::Rejection> + Clone + use<> {
@@ -113,7 +113,7 @@ mod handlers {
         logger: Logger,
         epoch_service: EpochServiceWrapper,
         http_message_service: Arc<dyn MessageService>,
-        max_artifact_epoch_offset: u32,
+        max_artifact_epoch_offset: u64,
     ) -> Result<impl warp::Reply, Infallible> {
         let expanded_epoch = match parameters::expand_epoch(&epoch, epoch_service).await {
             Ok(epoch) => epoch,
@@ -126,11 +126,11 @@ mod handlers {
             }
         };
 
-        if expanded_epoch.has_offset_greater_than(max_artifact_epoch_offset as u64) {
+        if expanded_epoch.has_offset_greater_than(max_artifact_epoch_offset) {
             return Ok(reply::bad_request(
                 "invalid_epoch".to_string(),
                 format!(
-                    "offset greater than max configured: epoch:`{epoch}`, max offset:`{max_artifact_epoch_offset}`"
+                    "offset greater than maximum allowed value: epoch:`{epoch}`, max offset:`{max_artifact_epoch_offset}`"
                 ),
             ));
         }

mithril-aggregator/src/http_server/routes/artifact_routes/cardano_stake_distribution.rs

@@ -121,7 +121,7 @@ pub mod handlers {
         http_message_service: Arc<dyn MessageService>,
         metrics_service: Arc<MetricsService>,
         epoch_service: EpochServiceWrapper,
-        max_artifact_epoch_offset: u32,
+        max_artifact_epoch_offset: u64,
     ) -> Result<impl warp::Reply, Infallible> {
         metrics_service
             .get_artifact_detail_cardano_stake_distribution_total_served_since_startup()
@@ -141,11 +141,11 @@ pub mod handlers {
             }
         };
 
-        if expanded_epoch.has_offset_greater_than(max_artifact_epoch_offset as u64) {
+        if expanded_epoch.has_offset_greater_than(max_artifact_epoch_offset) {
             return Ok(reply::bad_request(
                 "invalid_epoch".to_string(),
                 format!(
-                    "offset greater than max configured: epoch:`{epoch}`, max offset:`{max_artifact_epoch_offset}`"
+                    "offset greater than maximum allowed value: epoch:`{epoch}`, max offset:`{max_artifact_epoch_offset}`"
                 ),
             ));
         }

mithril-aggregator/src/http_server/routes/middlewares.rs

@@ -276,7 +276,7 @@ pub mod parameters {
                 .epoch_of_current_data()
                 .map(ExpandedEpoch::Latest)
         } else if epoch_str.starts_with("latest-") {
-            let (_, offset_str) = epoch_str.split_at(7);
+            let (_, offset_str) = epoch_str.split_at("latest-".len());
             let offset = offset_str
                 .parse::<u64>()
                 .with_context(|| "Invalid epoch offset: must be a number")?;
@@ -503,6 +503,8 @@ mod tests {
                 "latest+",
                 "latest+0",
                 "latest+293",
+                "latest-4.5",
+                "latest+2.9",
                 "latest-invalid",
             ] {
                 parameters::expand_epoch(invalid_epoch, epoch_service.clone())

mithril-aggregator/src/http_server/routes/router.rs

@@ -31,7 +31,7 @@ pub struct RouterConfig {
     pub allowed_discriminants: BTreeSet<SignedEntityTypeDiscriminants>,
     pub cardano_transactions_prover_max_hashes_allowed_by_request: usize,
     pub cardano_db_artifacts_directory: PathBuf,
-    pub max_artifact_epoch_offset: u32,
+    pub max_artifact_epoch_offset: u64,
     pub snapshot_directory: PathBuf,
     pub cardano_node_version: String,
     pub allow_http_serve_directory: bool,