feature(signer): add dependency injection for MithrilNetworkConfigurationProvider

Author: turmelclem

Cargo.lock

@@ -32,6 +32,7 @@ mithril-doc = { path = "../internal/mithril-doc" }
 mithril-era = { path = "../internal/mithril-era" }
 mithril-metric = { path = "../internal/mithril-metric" }
 mithril-persistence = { path = "../internal/mithril-persistence" }
+mithril-protocol-config = { path = "../internal/mithril-protocol-config" }
 mithril-signed-entity-lock = { path = "../internal/signed-entity/mithril-signed-entity-lock" }
 mithril-signed-entity-preloader = { path = "../internal/signed-entity/mithril-signed-entity-preloader" }
 mithril-ticker = { path = "../internal/mithril-ticker" }

mithril-signer/Cargo.toml

@@ -41,6 +41,8 @@ use mithril_persistence::database::repository::CardanoTransactionRepository;
 use mithril_persistence::database::{ApplicationNodeType, SqlMigration};
 use mithril_persistence::sqlite::{ConnectionBuilder, SqliteConnection, SqliteConnectionPool};
 
+use mithril_protocol_config::http_client::http_impl::HttpMithrilNetworkConfigurationProvider;
+
 #[cfg(feature = "future_dmq")]
 use mithril_dmq::{DmqMessageBuilder, DmqPublisherClientPallas};
 
@@ -503,6 +505,13 @@ impl<'a> DependenciesBuilder<'a> {
             self.root_logger(),
         ));
 
+        let network_configuration_service = Arc::new(HttpMithrilNetworkConfigurationProvider::new(
+            self.config.aggregator_endpoint.clone(),
+            self.config.relay_endpoint.clone(),
+            api_version_provider.clone(),
+            self.root_logger(),
+        ));
+
         let services = SignerDependencyContainer {
             ticker_service,
             certificate_handler: aggregator_client,
@@ -522,6 +531,7 @@ impl<'a> DependenciesBuilder<'a> {
             epoch_service,
             certifier,
             kes_signer,
+            network_configuration_service,
         };
 
         Ok(services)

mithril-signer/src/dependency_injection/builder.rs

@@ -9,6 +9,7 @@ use mithril_cardano_node_chain::chain_observer::ChainObserver;
 use mithril_cardano_node_internal_database::digesters::ImmutableDigester;
 use mithril_era::{EraChecker, EraReader};
 use mithril_persistence::store::StakeStorer;
+use mithril_protocol_config::interface::MithrilNetworkConfigurationProvider;
 use mithril_signed_entity_lock::SignedEntityTypeLock;
 use mithril_signed_entity_preloader::CardanoTransactionsPreloader;
 use mithril_ticker::TickerService;
@@ -26,6 +27,7 @@ type DigesterService = Arc<dyn ImmutableDigester>;
 type SingleSignerService = Arc<dyn SingleSigner>;
 type TimePointProviderService = Arc<dyn TickerService>;
 type ProtocolInitializerStoreService = Arc<dyn ProtocolInitializerStorer>;
+type MithrilNetworkConfigurationService = Arc<dyn MithrilNetworkConfigurationProvider>;
 
 /// EpochServiceWrapper wraps a [EpochService]
 pub type EpochServiceWrapper = Arc<RwLock<dyn EpochService>>;
@@ -85,4 +87,7 @@ pub struct SignerDependencyContainer {
 
     /// Kes signer service
     pub kes_signer: Option<Arc<dyn KesSigner>>,
+
+    /// Mithril network configuration service
+    pub network_configuration_service: MithrilNetworkConfigurationService,
 }

mithril-signer/src/dependency_injection/containers.rs

@@ -10,6 +10,7 @@ use mithril_common::entities::{
     Epoch, PartyId, ProtocolMessage, SignedEntityType, Signer, TimePoint,
 };
 use mithril_common::logging::LoggerExtensions;
+use mithril_protocol_config::model::MithrilNetworkConfiguration;
 
 use crate::Configuration;
 use crate::dependency_injection::SignerDependencyContainer;
@@ -19,6 +20,9 @@ use crate::services::{EpochService, MithrilProtocolInitializerBuilder};
 /// This trait is mainly intended for mocking.
 #[async_trait]
 pub trait Runner: Send + Sync {
+    ///Fetch the configuration parameters of a Mithril network
+    async fn get_mithril_network_configuration(&self) -> StdResult<MithrilNetworkConfiguration>;
+
     /// Fetch the current epoch settings if any.
     async fn get_epoch_settings(&self) -> StdResult<Option<SignerEpochSettings>>;
 
@@ -102,6 +106,12 @@ impl SignerRunner {
 #[cfg_attr(test, mockall::automock)]
 #[async_trait]
 impl Runner for SignerRunner {
+    async fn get_mithril_network_configuration(&self) -> StdResult<MithrilNetworkConfiguration> {
+        debug!(self.logger, ">> get_mithril_network_configuration");
+
+        self.services.network_configuration_service.get().await
+    }
+
     async fn get_epoch_settings(&self) -> StdResult<Option<SignerEpochSettings>> {
         debug!(self.logger, ">> get_epoch_settings");
 
@@ -359,6 +369,7 @@ mod tests {
         },
     };
     use mithril_era::{EraChecker, EraReader, adapters::EraReaderBootstrapAdapter};
+    use mithril_protocol_config::test::double::mithril_network_configuration_provider::FakeMithrilNetworkConfigurationProvider;
     use mithril_signed_entity_lock::SignedEntityTypeLock;
     use mithril_signed_entity_preloader::{
         CardanoTransactionsPreloader, CardanoTransactionsPreloaderActivation,
@@ -514,6 +525,9 @@ mod tests {
         ));
         let kes_signer = None;
 
+        let network_configuration_service =
+            Arc::new(FakeMithrilNetworkConfigurationProvider::default());
+
         SignerDependencyContainer {
             stake_store,
             certificate_handler: aggregator_client,
@@ -533,6 +547,7 @@ mod tests {
             epoch_service,
             certifier,
             kes_signer,
+            network_configuration_service,
         }
     }
 

mithril-signer/src/runtime/runner.rs

@@ -1,6 +1,7 @@
 #![allow(dead_code)]
 use anyhow::anyhow;
 use mithril_metric::{MetricCollector, MetricsServiceExporter};
+use mithril_protocol_config::test::double::mithril_network_configuration_provider::FakeMithrilNetworkConfigurationProvider;
 use prometheus_parse::Value;
 use slog::Drain;
 use slog_scope::debug;
@@ -294,6 +295,9 @@ impl StateMachineTester {
             config.operational_certificate_path.clone().unwrap(),
         )) as Arc<dyn KesSigner>);
 
+        let network_configuration_service =
+            Arc::new(FakeMithrilNetworkConfigurationProvider::default());
+
         let services = SignerDependencyContainer {
             certificate_handler: certificate_handler.clone(),
             ticker_service: ticker_service.clone(),
@@ -313,6 +317,7 @@ impl StateMachineTester {
             epoch_service,
             certifier,
             kes_signer,
+            network_configuration_service,
         };
         // set up stake distribution
         chain_observer.set_signers(signers_with_stake.to_owned()).await;