use property test to test BlockchainReader

Author: Aurélien Richez

src/main/scala/io/iohk/ethereum/db/storage/AppStateStorage.scala

@@ -32,7 +32,7 @@ class AppStateStorage(val dataSource: DataSource) extends TransactionalKeyValueS
     getBigInt(Keys.BestBlockNumber)
 
   def getBestBlockInfo(): BestBlockInfo =
-    BestBlockInfo( // FIXME default value for hash ?
+    BestBlockInfo( // TODO ETCM-1090 provide the genesis hash as default
       get(Keys.BestBlockHash).map(v => ByteString(Hex.decode(v))).getOrElse(ByteString.empty),
       getBigInt(Keys.BestBlockNumber)
     )

src/test/scala/io/iohk/ethereum/domain/BlockchainReaderSpec.scala

@@ -2,18 +2,23 @@ package io.iohk.ethereum.domain
 
 import org.scalatest.flatspec.AnyFlatSpec
 import org.scalatest.matchers.should.Matchers
-
-import io.iohk.ethereum.Fixtures
+import io.iohk.ethereum.{Fixtures, ObjectGenerators}
 import io.iohk.ethereum.blockchain.sync.EphemBlockchainTestSetup
+import io.iohk.ethereum.network.p2p.messages.BaseETH6XMessages.NewBlock
+import io.iohk.ethereum.security.SecureRandomBuilder
+import org.bouncycastle.util.encoders.Hex
+import org.scalatestplus.scalacheck.ScalaCheckPropertyChecks
 
-class BlockchainReaderSpec extends AnyFlatSpec with Matchers {
+class BlockchainReaderSpec extends AnyFlatSpec with Matchers with ScalaCheckPropertyChecks with SecureRandomBuilder {
 
-  "BlockchainReader" should "be able to get the best block after it was stored by BlockchainWriter" in new EphemBlockchainTestSetup {
-    val validBlock = Fixtures.Blocks.ValidBlock.block
+  val chainId: Option[Byte] = Hex.decode("3d").headOption
 
-    blockchainWriter.save(validBlock, Nil, ChainWeight.zero, true)
+  "BlockchainReader" should "be able to get the best block after it was stored by BlockchainWriter" in new EphemBlockchainTestSetup {
+    forAll(ObjectGenerators.newBlockGen(secureRandom, chainId)) { case NewBlock(block, weight) =>
+      blockchainWriter.save(block, Nil, ChainWeight(0, weight), true)
 
-    blockchainReader.getBestBlock() shouldBe Some(validBlock)
+      blockchainReader.getBestBlock() shouldBe Some(block)
+    }
   }
 
 }