Merge pull request #1020 from input-output-hk/feat/lw-9128-leftovers

chore: consistent object create and remove todo

Author: mirceahasegan

packages/cardano-services-client/src/TxSubmitProvider/txSubmitHttpProvider.ts

@@ -32,7 +32,7 @@ const paths: HttpProviderConfigPaths<TxSubmitProvider> = {
 const toTxSubmissionError = (error: any): TxSubmissionError | GeneralCardanoNodeError | null => {
   if (typeof error === 'object' && error !== null && typeof error?.message === 'string') {
     if (CardanoNodeUtil.isTxSubmissionErrorCode(error.code)) {
-      return Object.setPrototypeOf(error, TxSubmissionError.prototype);
+      return new TxSubmissionError(error.code, error.data, error.message);
     }
 
     if (CardanoNodeUtil.isGeneralCardanoNodeErrorCode(error.code)) {

packages/core/src/CardanoNode/util/cardanoNodeErrors.ts

@@ -14,8 +14,6 @@ import {
 } from '../types';
 import { isProductionEnvironment, stripStackTrace } from '@cardano-sdk/util';
 
-// TODO: test all new utils
-
 type InferObjectType<T> = T extends new (...args: any[]) => infer O ? O : never;
 
 const asSpecificCardanoNodeError =