From 4452fdaf7ec36c7f7cf376e3a162d4c43dbd0879 Mon Sep 17 00:00:00 2001 From: Simon Gellis Date: Thu, 23 Oct 2025 16:27:42 -0400 Subject: [PATCH] chore: use clippy in epochs_state --- .github/workflows/run-tests-on-push-to-main.yml | 1 + modules/epochs_state/src/epochs_state.rs | 12 ++++++------ modules/epochs_state/src/state.rs | 2 +- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/workflows/run-tests-on-push-to-main.yml b/.github/workflows/run-tests-on-push-to-main.yml index 9ac03567..dffc05c2 100644 --- a/.github/workflows/run-tests-on-push-to-main.yml +++ b/.github/workflows/run-tests-on-push-to-main.yml @@ -33,6 +33,7 @@ jobs: --package acropolis_module_chain_store \ --package acropolis_module_consensus \ --package acropolis_module_drdd_state \ + --package acropolis_module_epochs_state \ --package acropolis_module_mithril_snapshot_fetcher \ --package acropolis_module_snapshot_bootstrapper \ --package acropolis_module_spdd_state \ diff --git a/modules/epochs_state/src/epochs_state.rs b/modules/epochs_state/src/epochs_state.rs index 82770e9d..c7f12d42 100644 --- a/modules/epochs_state/src/epochs_state.rs +++ b/modules/epochs_state/src/epochs_state.rs @@ -130,9 +130,9 @@ impl EpochsState { }); if is_new_epoch { - let ea = state.end_epoch(&block_info); + let ea = state.end_epoch(block_info); // update epochs history - epochs_history.handle_epoch_activity(&block_info, &ea); + epochs_history.handle_epoch_activity(block_info, &ea); // publish epoch activity message epoch_activity_publisher .publish(Arc::new(Message::Cardano(( @@ -149,7 +149,7 @@ impl EpochsState { ); span.in_scope(|| { if let Some(header) = header.as_ref() { - match state.handle_block_header(&genesis, &block_info, &header) { + match state.handle_block_header(&genesis, block_info, header) { Ok(()) => {} Err(e) => error!("Error handling block header: {e}"), } @@ -160,7 +160,7 @@ impl EpochsState { span.in_scope(|| { if let Some(header) = header.as_ref() { if let Some(issuer_vkey) = header.issuer_vkey() { - state.handle_mint(&block_info, &issuer_vkey); + state.handle_mint(block_info, issuer_vkey); } } }); @@ -176,8 +176,8 @@ impl EpochsState { let span = info_span!("epochs_state.handle_block_txs", block = block_info.number); span.in_scope(|| { - Self::check_sync(¤t_block, &block_info); - state.handle_block_txs(&block_info, txs_msg); + Self::check_sync(¤t_block, block_info); + state.handle_block_txs(block_info, txs_msg); }); } diff --git a/modules/epochs_state/src/state.rs b/modules/epochs_state/src/state.rs index 417d8804..408e4998 100644 --- a/modules/epochs_state/src/state.rs +++ b/modules/epochs_state/src/state.rs @@ -251,7 +251,7 @@ impl State { total_outputs: self.epoch_outputs, total_fees: self.epoch_fees, spo_blocks: self.blocks_minted.iter().map(|(k, v)| (k.clone(), *v)).collect(), - nonce: self.nonces.as_ref().map(|n| n.active.hash.clone()).flatten(), + nonce: self.nonces.as_ref().and_then(|n| n.active.hash), } }