Merge pull request #280 from input-output-hk/sg/mithril-snapshot-fetcher-clippy

chore: use clippy on mithril_snapshot_fetcher

Author: SupernaviX

.github/workflows/run-tests-on-push-to-main.yml

@@ -33,6 +33,7 @@ jobs:
             --package acropolis_module_chain_store \
             --package acropolis_module_consensus \
             --package acropolis_module_drdd_state \
+            --package acropolis_module_mithril_snapshot_fetcher \
             --package acropolis_module_snapshot_bootstrapper \
             --package acropolis_module_spdd_state \
             --package acropolis_module_utxo_state

modules/mithril_snapshot_fetcher/src/mithril_snapshot_fetcher.rs

@@ -208,7 +208,7 @@ impl MithrilSnapshotFetcher {
         // Download the snapshot
         fs::create_dir_all(&directory)?;
         let dir = Path::new(&directory);
-        client.cardano_database().download_unpack(&snapshot, &dir).await?;
+        client.cardano_database().download_unpack(&snapshot, dir).await?;
 
         // Register download
         if let Err(e) = client.cardano_database().add_statistics(&snapshot).await {
@@ -281,9 +281,8 @@ impl MithrilSnapshotFetcher {
                         }
 
                         // Skip EBBs
-                        match block {
-                            MultiEraBlock::EpochBoundary(_) => return Ok::<(), anyhow::Error>(()),
-                            _ => {}
+                        if let MultiEraBlock::EpochBoundary(_) = block {
+                            return Ok(());
                         }
 
                         // Error and ignore any out of sequence
@@ -424,9 +423,8 @@ impl MithrilSnapshotFetcher {
                 delay = (delay * 2).min(60);
             }
 
-            match Self::process_snapshot(context, config, genesis).await {
-                Err(e) => error!("Failed to process Mithril snapshot: {e}"),
-                _ => {}
+            if let Err(e) = Self::process_snapshot(context, config, genesis).await {
+                error!("Failed to process Mithril snapshot: {e}");
             }
         });
 

modules/mithril_snapshot_fetcher/src/pause.rs

@@ -52,7 +52,7 @@ impl PauseType {
                 if block_info.new_epoch {
                     return block_info.epoch == *target_epoch;
                 }
-                return false;
+                false
             }
             PauseType::Block(target_block) => block_info.number == *target_block,
             PauseType::NoPause => false,