test: add support for multiple ruleset; add trailing semicolon fixture

Author: shvlv

tests/bootstrap.php

@@ -35,7 +35,7 @@
     die('Please install via Composer before running tests.');
 }
 
-putenv("SNIFFS_PATH={$libDir}/Inpsyde/Sniffs");
+putenv("LIB_PATH={$libDir}");
 putenv('SNIFFS_NAMESPACE=Inpsyde\\Sniffs');
 putenv("FIXTURES_PATH={$testsDir}/fixtures");
 

tests/cases/FixturesTest.php

@@ -209,24 +209,36 @@ private function createPhpcsForFixture(
         array $properties
     ): File {
 
-        $sniffFile = str_replace('.', '/', "{$sniffName}Sniff");
-        $sniffPath = getenv('SNIFFS_PATH') . "/{$sniffFile}.php";
+        $sniffFile = $this->buildSniffFile($sniffName);
+        $sniffPath = getenv('LIB_PATH') . "/{$sniffFile}.php";
         if (!file_exists($sniffPath) || !is_readable($sniffPath)) {
             // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
             throw new Exception("Non-existent of unreadable sniff file '{$sniffPath}' found.");
         }
 
+        $standard = strtok($sniffName, '.');
         $config = new Config();
-        $config->standards = [dirname(getenv('SNIFFS_PATH'))];
-        $config->sniffs = ["Inpsyde.{$sniffName}"];
+        $config->standards = [getenv('LIB_PATH') . "/{$standard}"];
+        $config->sniffs = [$sniffName];
         $ruleset = new Ruleset($config);
 
-        $baseSniffNamespace = getenv('SNIFFS_NAMESPACE');
         $sniffFqn = str_replace('/', '\\', $sniffFile);
         foreach ($properties as $name => $value) {
-            $ruleset->setSniffProperty("{$baseSniffNamespace}\\{$sniffFqn}", $name, $value);
+            $ruleset->setSniffProperty(
+                $sniffFqn,
+                $name,
+                ['scope' => 'sniff', 'value' => $value],
+            );
         }
 
         return new LocalFile($fixtureFile, $ruleset, $config);
     }
+
+    private function buildSniffFile(string $sniffName): string
+    {
+        $parts = explode('.', $sniffName);
+        array_splice($parts, 1, 0, 'Sniffs');
+
+        return implode('/', $parts) . 'Sniff';
+    }
 }

tests/fixtures/Psr4Fixture.php

@@ -1,5 +1,5 @@
 <?php # -*- coding: utf-8 -*-
-// @phpcsSniff CodeQuality.Psr4
+// @phpcsSniff Inpsyde.CodeQuality.Psr4
 
 namespace {
 

tests/fixtures/argument-type-declaration.php

@@ -1,5 +1,5 @@
 <?php
-// @phpcsSniff CodeQuality.ArgumentTypeDeclaration
+// @phpcsSniff Inpsyde.CodeQuality.ArgumentTypeDeclaration
 
 use Psr\Container as PsrContainer;
 

tests/fixtures/disable-call-user-func.php

@@ -1,5 +1,5 @@
 <?php
-// @phpcsSniff CodeQuality.DisableCallUserFunc
+// @phpcsSniff Inpsyde.CodeQuality.DisableCallUserFunc
 
 function test() {
     // @phpcsErrorOnNextLine

tests/fixtures/disallow-magic-serialize.php

@@ -1,6 +1,6 @@
 <?php
 
-// @phpcsSniff CodeQuality.DisableMagicSerialize
+// @phpcsSniff Inpsyde.CodeQuality.DisableMagicSerialize
 
 class Foo {
 

tests/fixtures/disallow-short-open-tag.php

@@ -13,7 +13,7 @@ function (string $sniff, array $messages, array $warnings, array $errors, array
 }
 // @phpcsProcessFixtureEnd
 
-// @phpcsSniff CodeQuality.DisallowShortOpenTag
+// @phpcsSniff Inpsyde.CodeQuality.DisallowShortOpenTag
 ?>
 <div>
     <?= strtolower($x) ?>

tests/fixtures/element-name-minimal-length.php

@@ -1,5 +1,5 @@
 <?php
-// @phpcsSniff CodeQuality.ElementNameMinimalLength
+// @phpcsSniff Inpsyde.CodeQuality.ElementNameMinimalLength
 
 namespace {
 

tests/fixtures/encoding-comment.php

@@ -3,7 +3,7 @@
 namespace Inpsyde\CodingStandard\Tests\Fixtures;
 
 
-// @phpcsSniff CodeQuality.EncodingComment
+// @phpcsSniff Inpsyde.CodeQuality.EncodingComment
 
 // @phpcsWarningCodeOnNextLine EncodingComment
 // -*- coding: utf-8 -*-
@@ -15,4 +15,4 @@
 
 <?php //-*- coding: utf-8 -*-
 // @phpcsWarningOnPreviousLine CodeQuality.EncodingComment
-?>
+?>

tests/fixtures/forbidden-public-property.php

@@ -1,5 +1,5 @@
 <?php
-// @phpcsSniff CodeQuality.ForbiddenPublicProperty
+// @phpcsSniff Inpsyde.CodeQuality.ForbiddenPublicProperty
 
 $foo = 'foo';