Added extensions parameter in upload API of javascript sdk #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 92.65% 94.47% +1.81%
==========================================
Files 9 9
Lines 177 181 +4
Branches 38 40 +2
==========================================
+ Hits 164 171 +7
+ Misses 6 4 -2
+ Partials 7 6 -1
Continue to review full report at Codecov.
|
imagekitio
requested changes
Nov 1, 2021
samples/sample-app/views/index.pug
Outdated
| fileName : file.files[0].name || "test_image.jpg", | ||
| tags : ["test_tag_1"] | ||
| tags : ["test_tag_1"], | ||
| extensions : [{name: "aws-auto-tagging", minConfidence: 80, maxTags: 10}] |
Collaborator
There was a problem hiding this comment.
Comment it out so that during testing, user don't end up consuming extension quota.
README.md
Outdated
| file: file.files[0], | ||
| fileName: "abc1.jpg", | ||
| tags: ["tag1"] | ||
| extensions: [{name: "aws-auto-tagging", minConfidence: 80, maxTags: 10}] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added extensions parameter support for Javascript SDK and related testcases.