test case fix

Author: manu4543

src/index.ts

@@ -3,6 +3,7 @@ import errorMessages from "./constants/errorMessages";
 import { ImageKitOptions, UploadOptions, UploadResponse, UrlOptions } from "./interfaces";
 import IKResponse from "./interfaces/IKResponse";
 import { upload } from "./upload/index";
+import respond from "./utils/respond";
 import { url } from "./url/index";
 import transformationUtils from "./utils/transformation";
 
@@ -80,14 +81,14 @@ class ImageKit {
   upload(uploadOptions: UploadOptions, callback: (err: Error | null, response: IKResponse<UploadResponse> | null) => void, options?: Partial<ImageKitOptions>): void;
   upload(uploadOptions: UploadOptions, callbackOrOptions?: ((err: Error | null, response: IKResponse<UploadResponse> | null) => void) | Partial<ImageKitOptions>, options?: Partial<ImageKitOptions>): void | Promise<IKResponse<UploadResponse>> {
     let callback;
-    if (typeof uploadOptions !== "object") {
-      throw ("First parameter needs to be object");
-    }
     if (typeof callbackOrOptions === 'function') {
       callback = callbackOrOptions;
     } else {
       options = callbackOrOptions || {};
     }
+    if (!uploadOptions || typeof uploadOptions !== "object") {
+      return respond(true, errorMessages.INVALID_UPLOAD_OPTIONS, callback);
+    }
     var mergedOptions = {
       ...this.options,
       ...options,

test/upload.js

@@ -102,16 +102,14 @@ describe("File upload", function () {
         server.restore();
     });
 
-    it('Invalid options', function (done) {
+    it('Invalid options', function () {
         var callback = sinon.spy();
 
-        try {
-            imagekit.upload(undefined, callback);
-        } catch (ex) {
-            // console.log(ex);
-            expect(ex).to.be.deep.equal("First parameter needs to be object");
-            done();
-        }
+        imagekit.upload(undefined, callback);
+        expect(server.requests.length).to.be.equal(0);
+        // await sleep()
+        expect(callback.calledOnce).to.be.true;
+        sinon.assert.calledWith(callback, { help: "", message: "Invalid uploadOptions parameter" }, null);
     });
 
     it('Missing fileName', function () {