fix: uploadFile throws 'Uncaught SyntaxError: Unexpected end of JSON input' when 500

Brian Noguchi · Brian Noguchi · commit 134d56f8fe43 · 2021-03-28T14:02:20.000-04:00
diff --git a/src/utils/request.js b/src/utils/request.js
@@ -82,7 +82,11 @@ export const uploadFile = (formData, callback) => {
         }
         else if (uploadFileXHR.status !== 200) {
             if (typeof callback != "function") return;
-            callback(JSON.parse(uploadFileXHR.responseText));
+            try {
+              callback(JSON.parse(uploadFileXHR.responseText));
+            } catch (ex) {
+              callback(ex);
+            }
         }
     };
     uploadFileXHR.send(formData);

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,11 @@ export const uploadFile = (formData, callback) => {`
`82`	`82`	`}`
`83`	`83`	`else if (uploadFileXHR.status !== 200) {`
`84`	`84`	`if (typeof callback != "function") return;`
`85`		`- callback(JSON.parse(uploadFileXHR.responseText));`
	`85`	`+ try {`
	`86`	`+ callback(JSON.parse(uploadFileXHR.responseText));`
	`87`	`+ } catch (ex) {`
	`88`	`+ callback(ex);`
	`89`	`+ }`
`86`	`90`	`}`
`87`	`91`	`};`
`88`	`92`	`uploadFileXHR.send(formData);`