Deprecate implicit bool to string coercion

Author: iluuu1994

Zend/tests/017.phpt

@@ -51,6 +51,8 @@ string(5) "array"
 int(%d)
 string(5) "array"
 int(%d)
+
+Deprecated: Implicit bool to string coercion is deprecated in %s on line %d
 bool(false)
 string(5) "array"
 int(%d)

Zend/tests/call_user_func_strict_arginfo_check.phpt

@@ -10,5 +10,6 @@ namespace Foo;
 var_dump(call_user_func('strlen', false));
 
 ?>
---EXPECT--
+--EXPECTF--
+Deprecated: Implicit bool to string coercion is deprecated in %s on line %d
 int(0)

Zend/tests/type_declarations/scalar_basic.phpt

@@ -197,9 +197,11 @@ string(%d) "%d"
 string(3) "NAN"
 
 *** Trying bool(true)
+E_DEPRECATED: Implicit bool to string coercion is deprecated on line 16
 string(1) "1"
 
 *** Trying bool(false)
+E_DEPRECATED: Implicit bool to string coercion is deprecated on line 16
 string(0) ""
 
 *** Trying NULL

Zend/tests/type_declarations/scalar_return_basic_64bit.phpt

@@ -158,8 +158,10 @@ string(19) "9223372036854775807"
 *** Trying float(NAN)
 string(3) "NAN"
 *** Trying bool(true)
+E_DEPRECATED: Implicit bool to string coercion is deprecated on line 16
 string(1) "1"
 *** Trying bool(false)
+E_DEPRECATED: Implicit bool to string coercion is deprecated on line 16
 string(0) ""
 *** Trying NULL
 *** Caught {closure}(): Return value must be of type string, null returned in %s on line %d

Zend/tests/type_declarations/union_types/type_checking_weak.phpt

@@ -181,8 +181,8 @@ INF              => "INF"
 "42x"            => "42x"
 "x"              => "x"
 ""               => ""
-true             => "1"
-false            => ""
+true             => "1" (Implicit bool to string coercion is deprecated)
+false            => "" (Implicit bool to string coercion is deprecated)
 null             => Argument ... must be of type array|string, null given
 []               => []
 new stdClass     => Argument ... must be of type array|string, stdClass given

Zend/zend_API.c

@@ -652,6 +652,9 @@ ZEND_API bool ZEND_FASTCALL zend_parse_arg_str_weak(zval *arg, zend_string **des
 		if (UNEXPECTED(Z_TYPE_P(arg) == IS_NULL) && !zend_null_arg_deprecated("string", arg_num)) {
 			return 0;
 		}
+		if (UNEXPECTED(Z_TYPE_P(arg) == IS_TRUE || Z_TYPE_P(arg) == IS_FALSE)) {
+			zend_error(E_DEPRECATED, "Implicit bool to string coercion is deprecated");
+		}
 		convert_to_string(arg);
 		*dest = Z_STR_P(arg);
 	} else if (UNEXPECTED(Z_TYPE_P(arg) == IS_OBJECT)) {

ext/iconv/tests/bug48147.phpt

@@ -20,8 +20,12 @@ bool(false)
 string(10) "aa%C3%B8aa"
 
 Notice: iconv(): Detected an incomplete multibyte character in input string in %s on line %d
+
+Deprecated: Implicit bool to string coercion is deprecated in %s on line %d
 string(0) ""
 string(8) "%C3%B8aa"
 
 Notice: iconv(): Detected an incomplete multibyte character in input string in %s on line %d
+
+Deprecated: Implicit bool to string coercion is deprecated in %s on line %d
 string(0) ""

ext/iconv/tests/iconv_mime_decode.phpt

@@ -70,12 +70,14 @@ do_regression_test();
 (32) "Subject: Prüfung PrüfungkůÔńÓlet"
 (31) "Subject: PrüfungPrüfungkůÔńÓlet"
 2: iconv_mime_decode(): Malformed string
+8192: Implicit bool to string coercion is deprecated
 (0) ""
 (27) "From: サンプル文字列サンプル文字列日本語テキスト"
 (31) "Subject: PrüfungPrüfungkůÔńÓlet"
 (32) "Subject: Prüfung PrüfungkůÔńÓlet"
 (100) "Subject: =?ISO-8859-1?Q?Pr=FCfung?==?ISO-8859-1*de_DE?Q?Pr=FCfung?==?ISO-8859-2?Q?k=F9=D4=F1=D3let?="
 2: iconv_mime_decode(): Malformed string
+8192: Implicit bool to string coercion is deprecated
 (0) ""
 (27) "From: サンプル文字列サンプル文字列日本語テキスト"
 (31) "Subject: PrüfungPrüfungkůÔńÓlet"

ext/json/tests/bug69187.phpt

@@ -26,7 +26,8 @@ var_dump(json_last_error());
 json_decode("\"\x00\"");
 var_dump(json_last_error());
 ?>
---EXPECT--
+--EXPECTF--
+Deprecated: Implicit bool to string coercion is deprecated in %s on line %d
 NULL
 int(4)
 NULL
@@ -35,6 +36,8 @@ int(0)
 int(0)
 int(1)
 int(0)
+
+Deprecated: Implicit bool to string coercion is deprecated in %s on line %d
 int(1)
 int(0)
 int(5)

ext/reflection/tests/005.phpt

@@ -46,9 +46,13 @@ foreach($r->getMethods() as $m)
 }
 
 ?>
---EXPECT--
+--EXPECTF--
 string(19) "Comment for class A"
 string(15) "Method A::bla()"
+
+Deprecated: Implicit bool to string coercion is deprecated in %s on line %d
 bool(false)
+
+Deprecated: Implicit bool to string coercion is deprecated in %s on line %d
 bool(false)
 string(22) "* Comment for A::baz()"