Skip to content

Make React Notification system compatible with react 17 or 18 #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Make React Notification system compatible with react 17 or 18 #184

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
66f25de
Update package.json
Oskku Oct 28, 2022
19fa1f2
Update package.json
Oskku Oct 28, 2022
34e3a3c
Update package.json
Oskku Oct 29, 2022
e18aa45
Update package.json
Oskku Oct 29, 2022
c6580ae
Update package.json
Oskku Oct 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@
"prop-types": "^15.5.6"
},
"peerDependencies": {
"react": "0.14.x || ^15.0.0 || ^16.0.0",
"react-dom": "0.14.x || ^15.0.0 || ^16.0.0"
"react":">=16.0.0",
"react-dom":">=16.0.0"
},
"devDependencies": {
"autoprefixer-loader": "^3.1.0",
Expand Down Expand Up @@ -70,11 +70,12 @@
"karma-webpack": "^1.7.0",
"mocha": "^4.0.1",
"node-sass": "^4.13.0",
"react": "^16.11.0",
"react-dom": "^16.11.0",
"react": ">=16.11.0",
"react-dom": ">=16.11.0",
"react-tools": "^0.13.2",
"react-transform-catch-errors": "^1.0.0",
"react-transform-hmr": "^1.0.1",
"create-react-class":"^15.7.0",
Copy link

@sbimochan sbimochan Dec 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this used? And please squash your commits.

Copy link

@ProgrammingWithOsku ProgrammingWithOsku Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry i left my old account should i push it from here again or ?

Copy link

@sbimochan sbimochan Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. maybe create a new PR. the commits looks naive

"redbox-react": "^1.1.1",
"rimraf": "^2.4.3",
"sass-loader": "^3.0.0",
Expand Down