From 559def65df88477df6d218891f8d3af449abdc13 Mon Sep 17 00:00:00 2001 From: Shashank Patidar Date: Tue, 26 Mar 2024 18:19:06 +0530 Subject: [PATCH 1/2] disable flaky test --- .../hypertrace/vertx/VertxClientInstrumentationTest.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/instrumentation/vertx/vertx-web-3.0/src/test/java/io/opentelemetry/javaagent/instrumentation/hypertrace/vertx/VertxClientInstrumentationTest.java b/instrumentation/vertx/vertx-web-3.0/src/test/java/io/opentelemetry/javaagent/instrumentation/hypertrace/vertx/VertxClientInstrumentationTest.java index efe1f187..831d1442 100644 --- a/instrumentation/vertx/vertx-web-3.0/src/test/java/io/opentelemetry/javaagent/instrumentation/hypertrace/vertx/VertxClientInstrumentationTest.java +++ b/instrumentation/vertx/vertx-web-3.0/src/test/java/io/opentelemetry/javaagent/instrumentation/hypertrace/vertx/VertxClientInstrumentationTest.java @@ -32,6 +32,7 @@ import java.util.concurrent.TimeoutException; import org.hypertrace.agent.testing.AbstractHttpClientTest; import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; public class VertxClientInstrumentationTest extends AbstractHttpClientTest { @@ -187,6 +188,7 @@ public void postJson_write_end_string() throws TimeoutException, InterruptedExce } @Test + @Disabled("This is flaky!!") public void postJson_write_end_buffer() throws TimeoutException, InterruptedException { String uri = String.format("http://localhost:%d/echo", testHttpServer.port()); From 9fab63f7437adbe3bade5a09548cc58ad6121bc3 Mon Sep 17 00:00:00 2001 From: Shashank Patidar Date: Tue, 26 Mar 2024 18:19:54 +0530 Subject: [PATCH 2/2] disable flaky test --- .../hypertrace/vertx/VertxClientInstrumentationTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/instrumentation/vertx/vertx-web-3.0/src/test/java/io/opentelemetry/javaagent/instrumentation/hypertrace/vertx/VertxClientInstrumentationTest.java b/instrumentation/vertx/vertx-web-3.0/src/test/java/io/opentelemetry/javaagent/instrumentation/hypertrace/vertx/VertxClientInstrumentationTest.java index 831d1442..96e8ca9b 100644 --- a/instrumentation/vertx/vertx-web-3.0/src/test/java/io/opentelemetry/javaagent/instrumentation/hypertrace/vertx/VertxClientInstrumentationTest.java +++ b/instrumentation/vertx/vertx-web-3.0/src/test/java/io/opentelemetry/javaagent/instrumentation/hypertrace/vertx/VertxClientInstrumentationTest.java @@ -188,7 +188,7 @@ public void postJson_write_end_string() throws TimeoutException, InterruptedExce } @Test - @Disabled("This is flaky!!") + @Disabled("This is flaky on github actions!!") public void postJson_write_end_buffer() throws TimeoutException, InterruptedException { String uri = String.format("http://localhost:%d/echo", testHttpServer.port());