Skip to content

Commit 021112a

Browse files
author
saxenakshitiz
committed
Address review comments
1 parent 799a86c commit 021112a

File tree

4 files changed

+23
-42
lines changed

4 files changed

+23
-42
lines changed
Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,30 @@
11
package org.hypertrace.graphql.label.schema;
22

3+
import graphql.annotations.annotationTypes.GraphQLField;
34
import graphql.annotations.annotationTypes.GraphQLName;
5+
import graphql.annotations.annotationTypes.GraphQLNonNull;
46
import org.hypertrace.core.graphql.common.schema.id.Identifiable;
7+
import org.hypertrace.core.graphql.common.schema.results.arguments.page.LimitArgument;
8+
import org.hypertrace.graphql.label.schema.rule.LabelApplicationRuleResultSet;
59

610
@GraphQLName(Label.TYPE_NAME)
7-
public interface Label extends Identifiable, LabelData, LabeledEntities, LabelApplicationRules {
11+
public interface Label extends Identifiable, LabelData {
812
String TYPE_NAME = "Label";
913
String ARGUMENT_NAME = "label";
14+
String LABELED_ENTITIES_QUERY_NAME = "labeledEntities";
15+
String ENTITY_TYPE_ARGUMENT_NAME = "type";
16+
String LABEL_APPLICATION_RULES_QUERY_NAME = "labelApplicationRules";
17+
18+
@GraphQLField
19+
@GraphQLNonNull
20+
@GraphQLName(LABELED_ENTITIES_QUERY_NAME)
21+
LabeledEntityResultSet labeledEntities(
22+
@GraphQLNonNull @GraphQLName(ENTITY_TYPE_ARGUMENT_NAME) String entityType,
23+
@GraphQLName(LimitArgument.ARGUMENT_NAME) int limit);
24+
25+
@GraphQLField
26+
@GraphQLNonNull
27+
@GraphQLName(LABEL_APPLICATION_RULES_QUERY_NAME)
28+
LabelApplicationRuleResultSet labelApplicationRules(
29+
@GraphQLName(LimitArgument.ARGUMENT_NAME) int limit);
1030
}

hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/schema/LabelApplicationRules.java

Lines changed: 0 additions & 19 deletions
This file was deleted.

hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/schema/LabeledEntities.java

Lines changed: 0 additions & 20 deletions
This file was deleted.

hypertrace-graphql-labels-schema-impl/src/main/java/org/hypertrace/graphql/label/joiner/DefaultEntityAndRuleJoinerBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package org.hypertrace.graphql.label.joiner;
22

33
import static io.reactivex.rxjava3.core.Single.zip;
4-
import static org.hypertrace.graphql.label.schema.LabelApplicationRules.LABEL_APPLICATION_RULES_QUERY_NAME;
5-
import static org.hypertrace.graphql.label.schema.LabeledEntities.LABELED_ENTITIES_QUERY_NAME;
4+
import static org.hypertrace.graphql.label.schema.Label.LABELED_ENTITIES_QUERY_NAME;
5+
import static org.hypertrace.graphql.label.schema.Label.LABEL_APPLICATION_RULES_QUERY_NAME;
66

77
import graphql.schema.DataFetchingFieldSelectionSet;
88
import graphql.schema.SelectedField;

0 commit comments

Comments
 (0)