Skip to content

refactor: attribute association expression rename #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2022

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Simple rename requested in hypertrace/hypertrace-graphql#128

@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #92 (37edfe3) into main (7be2e98) will decrease coverage by 0.04%.
The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #92      +/-   ##
============================================
- Coverage     58.74%   58.70%   -0.05%     
  Complexity      243      243              
============================================
  Files            86       86              
  Lines          1263     1264       +1     
  Branches         37       37              
============================================
  Hits            742      742              
- Misses          494      495       +1     
  Partials         27       27              
Flag Coverage Δ
unit 58.70% <44.44%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../core/graphql/common/request/AttributeRequest.java 0.00% <0.00%> (ø)
...e/graphql/utils/gateway/AttributeMapConverter.java 0.00% <0.00%> (ø)
...utils/gateway/SelectionExpressionSetConverter.java 0.00% <0.00%> (ø)
...common/request/DefaultAttributeRequestBuilder.java 68.42% <100.00%> (ø)
...ql/utils/gateway/AttributeExpressionConverter.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7be2e98...37edfe3. Read the comment docs.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit 43f084b into main Jan 9, 2022
@aaron-steinfeld aaron-steinfeld deleted the association-rename branch January 9, 2022 15:15
@github-actions
Copy link

github-actions bot commented Jan 9, 2022

Unit Test Results

31 files  ±0  31 suites  ±0   30s ⏱️ -2s
97 tests ±0  97 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 43f084b. ± Comparison against base commit 7be2e98.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants