feat: parallelize requests by default #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-steinfeld
requested review from
kotharironak,
laxman-traceable and
surajpuvvada
aaron-steinfeld
commented
Jun 9, 2022
| @@ -17,6 +17,9 @@ data: | |||
| graphql.urlPath = {{ .Values.serviceConfig.urlPath }} | |||
| graphql.corsEnabled = {{ .Values.serviceConfig.corsEnabled }} | |||
| graphql.timeout = {{ .Values.serviceConfig.timeoutDuration }} | |||
|
|
|||
| threads.io.max = {{ .Values.serviceConfig.threads.io }} | |||
There was a problem hiding this comment.
No change here, just exposing existing pool for config with same default.
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #102 +/- ##
============================================
+ Coverage 57.98% 58.37% +0.39%
- Complexity 253 255 +2
============================================
Files 86 87 +1
Lines 1290 1307 +17
Branches 39 39
============================================
+ Hits 748 763 +15
- Misses 512 514 +2
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tim-mwangi
approved these changes
Jun 9, 2022
|
Snyk resolved in #103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default graphql-java does not create threads. The container may create separate threads for different requests, and some of our implementations create threads to parallelize within a data fetcher, but if multiple queries come in the same HTTP request (batch), each will be executed in serial on the same thread by default.
With this change, we use a configurable thread pool to hand off execution at the GQL query level, rather than the HTTP request level.
Testing
Tested E2E as well as adding UTs
Checklist: