Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

feat(explore): support qs filters for eds #151

Draft
wants to merge 1 commit into
base: selective+single+source
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
package org.hypertrace.gateway.service.explore;

import static org.hypertrace.core.attribute.service.v1.AttributeSource.EDS;
import static org.hypertrace.gateway.service.common.ExpressionLocation.COLUMN_GROUP_BY;
import static org.hypertrace.gateway.service.common.ExpressionLocation.COLUMN_ORDER_BY;
import static org.hypertrace.gateway.service.common.ExpressionLocation.COLUMN_SELECTION;
import static org.hypertrace.gateway.service.common.ExpressionLocation.METRIC_AGGREGATION;
import static org.hypertrace.gateway.service.common.ExpressionLocation.METRIC_ORDER_BY;
import static org.hypertrace.gateway.service.common.ExpressionLocation.TIME_AGGREGATION;

import com.google.common.collect.ImmutableMap;
import io.micrometer.core.instrument.Timer;
Expand All @@ -9,6 +15,7 @@
import java.util.Arrays;
import java.util.Map;
import java.util.Optional;
import java.util.Set;
import java.util.concurrent.TimeUnit;
import org.hypertrace.core.attribute.service.v1.AttributeMetadata;
import org.hypertrace.core.serviceframework.metrics.PlatformMetricsRegistry;
Expand Down Expand Up @@ -120,7 +127,15 @@ private IRequestHandler getRequestHandler(
&& !hasTimeAggregations(request)
&& !request.getGroupByList().isEmpty()) {
Optional<String> source =
ExpressionContext.getSingleSourceForAllAttributes(expressionContext);
ExpressionContext.getSingleSourceForAttributes(
expressionContext,
Set.of(
COLUMN_SELECTION,
METRIC_AGGREGATION,
TIME_AGGREGATION,
COLUMN_ORDER_BY,
METRIC_ORDER_BY,
COLUMN_GROUP_BY));
if ((source.isPresent() && EDS.toString().equals(source.get())) || !hasTimeRange(request)) {
return entityRequestHandler;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,13 @@
import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.Streams;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.Set;
import java.util.stream.Collectors;
import org.hypertrace.core.attribute.service.v1.AttributeMetadata;
import org.hypertrace.core.attribute.service.v1.AttributeSource;
import org.hypertrace.entity.query.service.client.EntityQueryServiceClient;
import org.hypertrace.entity.query.service.v1.ColumnMetadata;
import org.hypertrace.entity.query.service.v1.ResultSetChunk;
Expand All @@ -19,13 +22,16 @@
import org.hypertrace.gateway.service.common.datafetcher.EntityFetcherResponse;
import org.hypertrace.gateway.service.common.datafetcher.QueryServiceEntityFetcher;
import org.hypertrace.gateway.service.common.util.AttributeMetadataUtil;
import org.hypertrace.gateway.service.common.util.ExpressionReader;
import org.hypertrace.gateway.service.common.util.MetricAggregationFunctionUtil;
import org.hypertrace.gateway.service.common.util.QueryServiceClient;
import org.hypertrace.gateway.service.entity.EntitiesRequestContext;
import org.hypertrace.gateway.service.entity.config.EntityIdColumnsConfigs;
import org.hypertrace.gateway.service.explore.ExploreRequestContext;
import org.hypertrace.gateway.service.explore.RequestHandler;
import org.hypertrace.gateway.service.v1.common.Filter;
import org.hypertrace.gateway.service.v1.common.FunctionExpression;
import org.hypertrace.gateway.service.v1.common.Operator;
import org.hypertrace.gateway.service.v1.entity.EntitiesRequest;
import org.hypertrace.gateway.service.v1.entity.Entity.Builder;
import org.hypertrace.gateway.service.v1.explore.ExploreRequest;
Expand Down Expand Up @@ -92,15 +98,24 @@ public ExploreResponse.Builder handleRequest(
requestContext.setHasGroupBy(true);
}

Set<String> entityIds = getEntityIds(requestContext, request);
Map<String, AttributeMetadata> attributeMetadataMap =
attributeMetadataProvider.getAttributesMetadata(requestContext, request.getContext());

Set<String> entityIds = getEntityIds(requestContext, expressionContext, attributeMetadataMap);
ExploreResponse.Builder builder = ExploreResponse.newBuilder();

if (entityIds.isEmpty()) {
return builder;
}

Optional<Filter> maybeEdsFilter =
buildFilter(request.getFilter(), AttributeSource.EDS, attributeMetadataMap);
ExploreRequest.Builder exploreEntityRequestBuilder =
ExploreRequest.newBuilder(request).clearFilter();
maybeEdsFilter.ifPresent(exploreEntityRequestBuilder::setFilter);
Iterator<ResultSetChunk> resultSetChunkIterator =
entityServiceEntityFetcher.getResults(requestContext, request, entityIds);
entityServiceEntityFetcher.getResults(
requestContext, exploreEntityRequestBuilder.build(), entityIds);

while (resultSetChunkIterator.hasNext()) {
org.hypertrace.entity.query.service.v1.ResultSetChunk chunk = resultSetChunkIterator.next();
Expand Down Expand Up @@ -144,22 +159,69 @@ public ExploreResponse.Builder handleRequest(
}

private Set<String> getEntityIds(
ExploreRequestContext requestContext, ExploreRequest exploreRequest) {
ExploreRequestContext requestContext,
ExpressionContext expressionContext,
Map<String, AttributeMetadata> attributeMetadataMap) {
ExploreRequest request = requestContext.getRequest();
EntitiesRequestContext entitiesRequestContext =
convert(attributeMetadataProvider, requestContext);
EntitiesRequest entitiesRequest =
EntitiesRequest.Builder entitiesRequestBuilder =
EntitiesRequest.newBuilder()
.setEntityType(exploreRequest.getContext())
.setStartTimeMillis(exploreRequest.getStartTimeMillis())
.setEndTimeMillis(exploreRequest.getEndTimeMillis())
.build();
.setEntityType(request.getContext())
.setStartTimeMillis(request.getStartTimeMillis())
.setEndTimeMillis(request.getEndTimeMillis());
// build qs filter from filter in the request
buildFilter(request.getFilter(), AttributeSource.QS, attributeMetadataMap)
.ifPresent(entitiesRequestBuilder::setFilter);
EntityFetcherResponse response =
queryServiceEntityFetcher.getEntities(entitiesRequestContext, entitiesRequest);
queryServiceEntityFetcher.getEntities(
entitiesRequestContext, entitiesRequestBuilder.build());
return response.getEntityKeyBuilderMap().values().stream()
.map(Builder::getId)
.collect(Collectors.toUnmodifiableSet());
}

private Optional<Filter> buildFilter(
Filter filter, AttributeSource source, Map<String, AttributeMetadata> attributeMetadataMap) {
if (filter.equals(Filter.getDefaultInstance())) {
return Optional.empty();
}

Operator operator = filter.getOperator();
switch (operator) {
case AND:
case OR:
return buildCompositeFilter(filter, source, operator, attributeMetadataMap);
default:
List<AttributeSource> sources =
attributeMetadataMap
.get(
ExpressionReader.getAttributeIdFromAttributeSelection(filter.getLhs())
.orElseThrow())
.getSourcesList();
return sources.contains(source)
? Optional.of(Filter.newBuilder(filter).build())
: Optional.empty();
}
}

private Optional<Filter> buildCompositeFilter(
Filter filter,
AttributeSource source,
Operator operator,
Map<String, AttributeMetadata> attributeMetadataMap) {
Filter.Builder filterBuilder = Filter.newBuilder();
for (Filter childFilter : filter.getChildFilterList()) {
buildFilter(childFilter, source, attributeMetadataMap).map(filterBuilder::addChildFilter);
}
if (filterBuilder.getChildFilterCount() > 0) {
filterBuilder.setOperator(operator);
return Optional.of(filterBuilder.build());
} else {
return Optional.empty();
}
}

private EntitiesRequestContext convert(
AttributeMetadataProvider attributeMetadataProvider, ExploreRequestContext requestContext) {
String entityType = requestContext.getContext();
Expand Down