diff --git a/.github/workflows/dep_rust.yml b/.github/workflows/dep_rust.yml index 4754e8156..66f0a0ff8 100644 --- a/.github/workflows/dep_rust.yml +++ b/.github/workflows/dep_rust.yml @@ -20,6 +20,16 @@ permissions: id-token: write contents: read +# The reason for default shell bash is because on our self-hosted windows runners, +# the default shell is powershell, which doesn't work correctly together with `just` commands. +# Even if a command inside a just-recipe fails, github reports the step as successful. +# The problem may or may not be related to our custom windows runner not applying the +# powershell steps outlined here +# https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference +defaults: + run: + shell: bash + jobs: build: if: ${{ inputs.docs_only == 'false' }} @@ -71,7 +81,6 @@ jobs: - name: Verify MSRV run: ./dev/verify-msrv.sh hyperlight-host hyperlight-guest hyperlight-common - shell: bash - name: Run Rust tests env: