Enable gdb tests on Windows

Signed-off-by: James Sturtevant <[email protected]>

Author: jsturtevant

.github/workflows/dep_rust.yml

@@ -157,8 +157,7 @@ jobs:
           RUST_LOG: debug
         run: just run-rust-examples-linux ${{ matrix.config }} ${{ matrix.hypervisor == 'mshv' && 'mshv2' || ''}}
 
-      - name: Run Rust Gdb tests - linux
-        if: runner.os == 'Linux'
+      - name: Run Rust Gdb tests
         env:
           CARGO_TERM_COLOR: always
           RUST_LOG: debug

Justfile

@@ -126,8 +126,8 @@ like-ci config=default-target hypervisor="kvm":
     @# Run Rust examples - linux
     {{ if os() == "linux" { "just run-rust-examples-linux " + config + " " + if hypervisor == "mshv" { "mshv2" } else if hypervisor == "mshv3" { "mshv3" } else { "kvm" } } else { "" } }}
 
-    @# Run Rust Gdb tests - linux
-    {{ if os() == "linux" { "just test-rust-gdb-debugging " + config + " " + if hypervisor == "mshv" { "mshv2" } else if hypervisor == "mshv3" { "mshv3" } else { "kvm" } } else { "" } }}
+    @# Run Rust Gdb tests
+    just test-rust-gdb-debugging {{ config }} {{ if hypervisor == "mshv" { "mshv2" } else if hypervisor == "mshv3" { "mshv3" } else { "kvm" } }} 
 
     @# Run Rust Crashdump tests
     just test-rust-crashdump {{config}} {{ if hypervisor == "mshv" { "mshv2" } else if hypervisor == "mshv3" { "mshv3" } else { "kvm" } }}

src/hyperlight_host/examples/guest-debugging/main.rs

@@ -111,6 +111,11 @@ mod tests {
 
     use super::*;
 
+    #[cfg(not(windows))]
+    const GDB_COMMAND: &str = "rust-gdb";
+    #[cfg(windows)]
+    const GDB_COMMAND: &str = "gdb";
+
     fn write_cmds_file(cmd_file_path: &str, cmd: &str) -> io::Result<()> {
         let file = File::create(cmd_file_path)?;
         let mut writer = BufWriter::new(file);
@@ -150,7 +155,7 @@ mod tests {
         // wait 3 seconds for the gdb to connect
         thread::sleep(Duration::from_secs(3));
 
-        let mut gdb = Command::new("rust-gdb")
+        let mut gdb = Command::new(GDB_COMMAND)
             .arg("--nw")
             .arg("--batch")
             .arg("-x")
@@ -235,7 +240,9 @@ mod tests {
     #[serial]
     fn test_gdb_end_to_end() {
         let out_dir = std::env::var("OUT_DIR").expect("Failed to get out dir");
-        let manifest_dir = std::env::var("CARGO_MANIFEST_DIR").expect("Failed to get manifest dir");
+        let manifest_dir = std::env::var("CARGO_MANIFEST_DIR")
+            .expect("Failed to get manifest dir")
+            .replace('\\', "/");
         let out_file_path = format!("{out_dir}/gdb.output");
         let cmd_file_path = format!("{out_dir}/gdb-commands.txt");
 
@@ -262,6 +269,9 @@ mod tests {
             "
         );
 
+        #[cfg(windows)]
+        let cmd = format!("set osabi none\n{}", cmd);
+
         let checker = |contents: String| contents.contains("Stopped at hyperlight_main breakpoint");
 
         let result = run_guest_and_gdb(&cmd_file_path, &out_file_path, &cmd, checker);
@@ -277,7 +287,10 @@ mod tests {
     #[serial]
     fn test_gdb_sse_check() {
         let out_dir = std::env::var("OUT_DIR").expect("Failed to get out dir");
-        let manifest_dir = std::env::var("CARGO_MANIFEST_DIR").expect("Failed to get manifest dir");
+        let manifest_dir = std::env::var("CARGO_MANIFEST_DIR")
+            .expect("Failed to get manifest dir")
+            .replace('\\', "/");
+        println!("manifest dir {manifest_dir}");
         let out_file_path = format!("{out_dir}/gdb-sse.output");
         let cmd_file_path = format!("{out_dir}/gdb-sse--commands.txt");
 
@@ -308,6 +321,9 @@ mod tests {
             "
         );
 
+        #[cfg(windows)]
+        let cmd = format!("set osabi none\n{}", cmd);
+
         let checker = |contents: String| contents.contains("$2 = [1.20000005, 0, 0, 0]");
         let result = run_guest_and_gdb(&cmd_file_path, &out_file_path, &cmd, checker);