Skip to content

Commit 4c135f7

Browse files
committed
Fix 'download benchmark' workflow
1 parent f0e4574 commit 4c135f7

File tree

2 files changed

+30
-42
lines changed

2 files changed

+30
-42
lines changed

.github/workflows/Benchmarks.yml

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,6 @@ jobs:
1717
strategy:
1818
fail-fast: true
1919
matrix:
20-
build: [
21-
windows-2022-release-amd,
22-
linux-kvm-release-amd,
23-
linux-hyperv-release-amd,
24-
windows-2022-release-intel,
25-
linux-kvm-release-intel,
26-
linux-hyperv-release-intel,
27-
]
2820
include:
2921
- build: windows-2022-release-amd
3022
os: [self-hosted, Windows, X64, "1ES.Pool=hld-win2022-amd"]
@@ -34,9 +26,9 @@ jobs:
3426
os: [self-hosted, Linux, X64, "1ES.Pool=hld-kvm-amd"]
3527
hypervisor: kvm
3628
arch: amd
37-
- build: linux-hyperv-release-amd
29+
- build: linux-mshv-release-amd
3830
os: [self-hosted, Linux, X64, "1ES.Pool=hld-mshv-amd"]
39-
hypervisor: hyperv
31+
hypervisor: mshv
4032
arch: amd
4133
- build: windows-2022-release-intel
4234
os: [self-hosted, Windows, X64, "1ES.Pool=hld-win2022-intel"]
@@ -46,9 +38,9 @@ jobs:
4638
os: [self-hosted, Linux, X64, "1ES.Pool=hld-kvm-intel"]
4739
hypervisor: kvm
4840
arch: intel
49-
- build: linux-hyperv-release-intel
41+
- build: linux-mshv-release-intel
5042
os: [self-hosted, Linux, X64, "1ES.Pool=hld-mshv-intel"]
51-
hypervisor: hyperv
43+
hypervisor: mshv
5244
arch: intel
5345

5446
runs-on: ${{ matrix.os }}

.github/workflows/dep_rust.yml

Lines changed: 26 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -26,70 +26,66 @@ jobs:
2626
strategy:
2727
fail-fast: true
2828
matrix:
29-
build:
30-
[
31-
windows-2022-debug-amd,
32-
linux-kvm-debug-amd,
33-
linux-hyperv-debug-amd,
34-
windows-2022-release-amd,
35-
linux-kvm-release-amd,
36-
linux-hyperv-release-amd,
37-
windows-2022-debug-intel,
38-
linux-kvm-debug-intel,
39-
linux-hyperv-debug-intel,
40-
windows-2022-release-intel,
41-
linux-kvm-release-intel,
42-
linux-hyperv-release-intel,
43-
]
4429
include:
4530
- build: windows-2022-debug-amd
4631
os: [self-hosted, Windows, X64, "1ES.Pool=hld-win2022-amd"]
47-
hypervisor: none
32+
hypervisor: hyperv
4833
config: debug
34+
arch: amd
4935
- build: linux-kvm-debug-amd
5036
os: [self-hosted, Linux, X64, "1ES.Pool=hld-kvm-amd"]
5137
hypervisor: kvm
5238
config: debug
53-
- build: linux-hyperv-debug-amd
39+
arch: amd
40+
- build: linux-mshv-debug-amd
5441
os: [self-hosted, Linux, X64, "1ES.Pool=hld-mshv-amd"]
55-
hypervisor: hyperv
42+
hypervisor: mshv
5643
config: debug
44+
arch: amd
5745
- build: windows-2022-release-amd
5846
os: [self-hosted, Windows, X64, "1ES.Pool=hld-win2022-amd"]
59-
hypervisor: none
47+
hypervisor: hyperv
6048
config: release
49+
arch: amd
6150
- build: linux-kvm-release-amd
6251
os: [self-hosted, Linux, X64, "1ES.Pool=hld-kvm-amd"]
6352
hypervisor: kvm
6453
config: release
65-
- build: linux-hyperv-release-amd
54+
arch: amd
55+
- build: linux-mshv-release-amd
6656
os: [self-hosted, Linux, X64, "1ES.Pool=hld-mshv-amd"]
67-
hypervisor: hyperv
57+
hypervisor: mshv
6858
config: release
6959
- build: windows-2022-debug-intel
7060
os: [self-hosted, Windows, X64, "1ES.Pool=hld-win2022-intel"]
71-
hypervisor: none
61+
hypervisor: hyperv
7262
config: debug
63+
arch: intel
7364
- build: linux-kvm-debug-intel
7465
os: [self-hosted, Linux, X64, "1ES.Pool=hld-kvm-intel"]
7566
hypervisor: kvm
7667
config: debug
77-
- build: linux-hyperv-debug-intel
68+
arch: intel
69+
- build: linux-mshv-debug-intel
7870
os: [self-hosted, Linux, X64, "1ES.Pool=hld-mshv-intel"]
79-
hypervisor: hyperv
71+
hypervisor: mshv
8072
config: debug
73+
arch: intel
8174
- build: windows-2022-release-intel
8275
os: [self-hosted, Windows, X64, "1ES.Pool=hld-win2022-intel"]
83-
hypervisor: none
76+
hypervisor: hyperv
8477
config: release
78+
arch: intel
8579
- build: linux-kvm-release-intel
8680
os: [self-hosted, Linux, X64, "1ES.Pool=hld-kvm-intel"]
8781
hypervisor: kvm
8882
config: release
89-
- build: linux-hyperv-release-intel
83+
arch: intel
84+
- build: linux-mshv-release-intel
9085
os: [self-hosted, Linux, X64, "1ES.Pool=hld-mshv-intel"]
91-
hypervisor: hyperv
86+
hypervisor: mshv
9287
config: release
88+
arch: intel
9389

9490
runs-on: ${{ matrix.os }}
9591
steps:
@@ -133,7 +129,7 @@ jobs:
133129
just test-rust ${{ matrix.config }}
134130
135131
# with only one driver enabled (driver mshv/kvm feature is ignored on windows) + seccomp + inprocess
136-
just test-rust ${{ matrix.config }} inprocess,seccomp,${{ matrix.hypervisor == 'hyperv' && 'mshv' || 'kvm' }}
132+
just test-rust ${{ matrix.config }} inprocess,seccomp,${{ matrix.hypervisor == 'mshv' && 'mshv' || 'kvm' }}
137133
138134
# without any driver (shouldn't compile)
139135
just test-rust-feature-compilation-fail ${{ matrix.config }}
@@ -155,15 +151,15 @@ jobs:
155151

156152
### Benchmarks ###
157153
- name: Install github-cli (Linux mariner)
158-
if: runner.os == 'Linux' && matrix.hypervisor == 'hyperv'
154+
if: runner.os == 'Linux' && matrix.hypervisor == 'mshv'
159155
run: sudo dnf install gh -y
160156

161157
- name: Install github-cli (Linux ubuntu)
162158
if: runner.os == 'Linux' && matrix.hypervisor == 'kvm'
163159
run: sudo apt install gh -y
164160

165161
- name: Download benchmarks from "latest"
166-
run: just bench-download ${{ runner.os }} ${{ matrix.hypervisor }} dev-latest # compare to prerelease
162+
run: just bench-download ${{ runner.os }} ${{ matrix.hypervisor }} ${{ matrix.arch}} dev-latest # compare to prerelease
167163
env:
168164
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
169165
continue-on-error: true

0 commit comments

Comments
 (0)