openapi: all array elements should be non-nullable

awrichar · awrichar · commit 4ef131e425d6 · 2025-05-01T11:41:53.000-04:00
There is never a case where we allow nulls to be mixed into an array.

Signed-off-by: Andrew Richardson &lt;andrew.richardson@kaleido.io&gt;
diff --git a/pkg/ffapi/openapi3.go b/pkg/ffapi/openapi3.go
@@ -206,6 +206,10 @@ func (sg *SwaggerGen) addCustomType(t reflect.Type, schema *openapi3.Schema) {
 		True := true
 		schema.AdditionalProperties = openapi3.AdditionalProperties{Has: &True}
 	}
+
+	if schema.Items != nil && schema.Items.Value != nil {
+		schema.Items.Value.Nullable = false
+	}
 }
 
 func (sg *SwaggerGen) addInput(ctx context.Context, doc *openapi3.T, route *Route, op *openapi3.Operation) {

Original file line number	Diff line number	Diff line change
`@@ -206,6 +206,10 @@ func (sg SwaggerGen) addCustomType(t reflect.Type, schema openapi3.Schema) {`
`206`	`206`	`True := true`
`207`	`207`	`schema.AdditionalProperties = openapi3.AdditionalProperties{Has: &True}`
`208`	`208`	`}`
	`209`	`+`
	`210`	`+ if schema.Items != nil && schema.Items.Value != nil {`
	`211`	`+ schema.Items.Value.Nullable = false`
	`212`	`+ }`
`209`	`213`	`}`
`210`	`214`
`211`	`215`	`func (sg SwaggerGen) addInput(ctx context.Context, doc openapi3.T, route Route, op openapi3.Operation) {`