Skip to content

Return Flax scheduler state #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 21, 2022
Merged

Return Flax scheduler state #601

merged 5 commits into from
Sep 21, 2022

Conversation

@pcuenca
Copy link
Member

@pcuenca pcuenca commented Sep 21, 2022

This was initially done as part of #583.

The way to set up a custom scheduler, as discussed offline, is:

scheduler, scheduler_state = FlaxPNDMScheduler.from_config(...)
pipeline, params = FlaxStableDiffusionPipeline.from_pretrained(
    model_id,
    scheduler=scheduler,
)
params["scheduler"] = scheduler_state

@pcuenca
Optionally return state in from_config.
9e2055e 
Useful for Flax schedulers.
@pcuenca
has_state is now a property, make check more strict.
f674320 
I don't check the class is `SchedulerMixin` to prevent circular
dependencies. It should be enough that the class name starts with "Flax"
the object declares it "has_state" and the "create_state" exists too.
@pcuenca
Use state in pipeline from_pretrained.
5ab5c4e
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 21, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

patil-suraj
patil-suraj approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pcuenca pcuenca merged commit a9fdb3d into main Sep 21, 2022
@pcuenca pcuenca deleted the return_scheduler_state branch September 21, 2022 20:25
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@pcuenca
Return Flax scheduler state (huggingface#601)
b65a131 
* Optionally return state in from_config.

Useful for Flax schedulers.

* has_state is now a property, make check more strict.

I don't check the class is `SchedulerMixin` to prevent circular
dependencies. It should be enough that the class name starts with "Flax"
the object declares it "has_state" and the "create_state" exists too.

* Use state in pipeline from_pretrained.

* Make style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kashif kashif kashif approved these changes

@mishig25 mishig25 Awaiting requested review from mishig25

@patrickvonplaten patrickvonplaten Awaiting requested review from patrickvonplaten

+1 more reviewer

@patil-suraj patil-suraj patil-suraj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pcuenca @HuggingFaceDocBuilderDev @kashif @patil-suraj