Flax: ignore dtype for configuration #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to save models and configuration files.
|
The documentation is not available anymore as the PR was closed or merged. |
mishig25
reviewed
Sep 19, 2022
| config_name = CONFIG_NAME | ||
| _automatically_saved_args = ["_diffusers_version", "_class_name", "_name_or_path"] | ||
| _flax_internal_args = ["name", "parent"] | ||
| _flax_internal_args = ["name", "parent", "dtype"] |
Contributor
There was a problem hiding this comment.
did you receive a warning while initializing?
Member
Author
There was a problem hiding this comment.
did you receive a warning while initializing?
Not about dtype. In the case of the VAE, for example, I did the following tests:
- Loaded from the current configuration in
fusing. Then I got this warning:
The config attributes {'architectures': ['encoderKL'], 'double_z': True, 'transformers_version': '4.21.0.dev0'} were passed to FlaxAutoencoderKL, but are not expected and will be ignored. Please verify your config.json configuration file.
- Saved the configuration.
- Saved the pretrained weights.
- Loaded from the saved pretrained weights. No warning was emitted here.
Merged
Contributor
|
Ok removing for now. Overall I was actually in favor of keeping it in because if someone trains a model with
@pcuenca could you maybe open a "Feature request" issue after merging this that reminds us to eventually save this param? |
patrickvonplaten
approved these changes
Sep 19, 2022
2 tasks
PhaneeshB
pushed a commit
to nod-ai/diffusers
that referenced
this pull request
Mar 1, 2023
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
Flax: ignore dtype for configuration. This makes it possible to save models and configuration files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to save weights and configuration files.