expose polynomial:power and cosine_with_restarts:num_cycles params #1737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_scheduler func, add it to train_dreambooth.py
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
Author
|
What's done:
Haven't found any test script in test folder that tests optimizers.py |
pcuenca
approved these changes
Dec 19, 2022
Member
pcuenca
left a comment
pcuenca
left a comment
There was a problem hiding this comment.
Looks good!
An alternative would be to use scheduler_kwargs in get_scheduler, but since we only have those two configurable schedulers I think it's good for now.
Co-authored-by: Pedro Cuenca <[email protected]>
patrickvonplaten
approved these changes
Dec 20, 2022
Contributor
patrickvonplaten
left a comment
patrickvonplaten
left a comment
There was a problem hiding this comment.
Thanks @zetyquickly
sliard
pushed a commit
to sliard/diffusers
that referenced
this pull request
Dec 21, 2022
…uggingface#1737) * expose polynomial:power and cosine_with_restarts:num_cycles using get_scheduler func, add it to train_dreambooth.py * fix formatting * fix style * Update src/diffusers/optimization.py Co-authored-by: Pedro Cuenca <[email protected]> Co-authored-by: Pedro Cuenca <[email protected]>
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
…uggingface#1737) * expose polynomial:power and cosine_with_restarts:num_cycles using get_scheduler func, add it to train_dreambooth.py * fix formatting * fix style * Update src/diffusers/optimization.py Co-authored-by: Pedro Cuenca <[email protected]> Co-authored-by: Pedro Cuenca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to get_scheduler func,