Skip to content

[HIG-2525] ensure highlight-mask blocks image src #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2022
Merged

[HIG-2525] ensure highlight-mask blocks image src #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c75727c
ensure highlight-mask blocks image src
Vadman97 Aug 3, 2022
8bd2214
bump versions
Vadman97 Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/rrdom-nodejs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
},
"dependencies": {
"@highlight-run/rrdom": "0.1.17",
"@highlight-run/rrweb-snapshot": "1.1.25",
"@highlight-run/rrweb-snapshot": "1.1.26",
"cssom": "^0.5.0",
"cssstyle": "^2.3.0",
"nwsapi": "^2.2.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/rrdom/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"typescript": "^4.7.3"
},
"dependencies": {
"@highlight-run/rrweb-snapshot": "1.1.25"
"@highlight-run/rrweb-snapshot": "1.1.26"
},
"gitHead": "d5751f9e6c52a7734597c8595caa763d0f4dd4ad"
}
2 changes: 1 addition & 1 deletion packages/rrweb-snapshot/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@highlight-run/rrweb-snapshot",
"version": "1.1.25",
"version": "1.1.26",
"description": "rrweb's component to take a snapshot of DOM, aka DOM serializer",
"scripts": {
"prepare": "npm run prepack",
Expand Down
7 changes: 6 additions & 1 deletion packages/rrweb-snapshot/src/snapshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,7 @@ function serializeNode(
inlineStylesheet,
maskInputOptions,
maskInputFn,
maskTextClass,
dataURLOptions,
inlineImages,
recordCanvas,
Expand Down Expand Up @@ -647,6 +648,7 @@ function serializeElementNode(
inlineStylesheet: boolean;
maskInputOptions: MaskInputOptions;
maskInputFn: MaskInputFn | undefined;
maskTextClass: string | RegExp;
dataURLOptions?: DataURLOptions;
inlineImages: boolean;
recordCanvas: boolean;
Expand All @@ -666,6 +668,7 @@ function serializeElementNode(
inlineStylesheet,
maskInputOptions = {},
maskInputFn,
maskTextClass,
dataURLOptions = {},
inlineImages,
recordCanvas,
Expand All @@ -674,7 +677,9 @@ function serializeElementNode(
enableStrictPrivacy,
rootId,
} = options;
let needBlock = _isBlockedElement(n, blockClass, blockSelector);
let needBlock =
_isBlockedElement(n, blockClass, blockSelector) ||
_isBlockedElement(n, maskTextClass, blockSelector);
const tagName = getValidTagName(n);
let attributes: attributes = {};
const len = n.attributes.length;
Expand Down
4 changes: 2 additions & 2 deletions packages/rrweb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@highlight-run/rrweb",
"version": "2.1.2",
"version": "2.1.3",
"description": "record and replay the web",
"scripts": {
"prepare": "npm run prepack",
Expand Down Expand Up @@ -76,7 +76,7 @@
},
"dependencies": {
"@highlight-run/rrdom": "0.1.17",
"@highlight-run/rrweb-snapshot": "1.1.25",
"@highlight-run/rrweb-snapshot": "1.1.26",
"@types/css-font-loading-module": "0.0.7",
"@xstate/fsm": "^1.4.0",
"base64-arraybuffer": "^1.0.1",
Expand Down