-
Notifications
You must be signed in to change notification settings - Fork 39
#168 Service worker #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
#168 Service worker #680
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
51904be
Added service worker that caches pages and allows users to view them …
M4ttoF cab75df
Fixed google map errors with caching and added some changed to enviro…
M4ttoF 4919617
Completed changes to hide API Key
M4ttoF 07dfcd9
Checks if user is running it as a PWA before launching service worker
M4ttoF File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,4 +34,4 @@ public function manifest() | |
| ] | ||
| ]); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,5 +15,8 @@ | |
| "lodash": "^4.16.2", | ||
| "vue": "^2.0.1", | ||
| "vue-resource": "^1.0.3" | ||
| }, | ||
| "dependencies": { | ||
| "firebase": "^5.3.0" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| importScripts('https://www.gstatic.com/firebasejs/4.8.1/firebase-app.js'); | ||
| importScripts('https://www.gstatic.com/firebasejs/4.8.1/firebase-messaging.js'); | ||
| firebase.initializeApp({ | ||
| messagingSenderId: "your messagingSenderId again" | ||
| }); | ||
| const messaging = firebase.messaging(); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| var url= window.location.href; | ||
| var pos = url.search('using_pwa'); | ||
|
|
||
| if (pos+1 && url[pos+8] && 'serviceWorker' in navigator) { | ||
| navigator.serviceWorker | ||
| .register('./service-worker.js', { scope: './'}) | ||
| .then((registration)=> { | ||
| firebase.messaging().useServiceWorker(registration); | ||
| }) | ||
| .catch(function(err) { | ||
| console.log("Service Worker Failed to Register", err); | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| var cacheName = 'v1'; | ||
|
|
||
| var cacheFiles = []; | ||
|
|
||
| self.addEventListener('install', function(e) { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where is "self" defined? |
||
| try { | ||
| e.waitUntil( | ||
| caches.open(cacheName).then(function(cache) { | ||
| return cache.addAll(cacheFiles); | ||
| }) | ||
| ) | ||
| } catch(e) { | ||
| console.log(e); | ||
| } | ||
|
|
||
| }) | ||
|
|
||
| self.addEventListener('activate', function(e) { | ||
| e.waitUntil( | ||
| caches.keys().then(function(cacheNames) { | ||
| return Promise.all(cacheNames.map(function(thisCacheName) { | ||
|
|
||
| if (thisCacheName !== cacheName) { | ||
| return caches.delete(thisCacheName); | ||
| } | ||
| })); | ||
| }) | ||
| ); | ||
| e.waitUntil( | ||
|
|
||
| caches.keys().then(function(cacheNames) { | ||
| return Promise.all(cacheNames.map(function(thisCacheName) { | ||
|
|
||
| if (thisCacheName !== cacheName) { | ||
| return caches.delete(thisCacheName); | ||
| } | ||
| })); | ||
| }) | ||
| ); | ||
| }) | ||
|
|
||
| self.addEventListener('fetch',function(e) { | ||
|
|
||
| if (e.request.url.indexOf('https://maps.googleapi.com') !== 0 || | ||
| e.request.url.indexOf('http://maps.googleapis.com') !== 0) { | ||
| e.respondWith( | ||
| caches.match(e.request) | ||
| .then(function(response) { | ||
|
|
||
| if (response) { | ||
| return response; | ||
| } | ||
|
|
||
| var requestClone = e.request.clone(); | ||
| return fetch(requestClone) | ||
| .then(function(response) { | ||
|
|
||
| if (!response) { | ||
| return response; | ||
| } | ||
|
|
||
| var responseClone = response.clone(); | ||
| caches.open(cacheName).then(function(cache) { | ||
| cache.put(e.request, responseClone) | ||
| .catch(function(err) { | ||
| console.log('Post Request Made', err); | ||
| }); | ||
| return response; | ||
| }); | ||
|
|
||
| }) | ||
| .catch(function(err) { | ||
| console.log('[ServiceWorker] Error Fetching & Caching New Data', err); | ||
| }); | ||
| }) | ||
| ); | ||
| } | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure where this is coming from but there are some JavaScript errors when visiting the home page of the site. The errors lead to the Google Map not working.
I did not install firebase on app.accesslocator.com. Would that be the cause?
Here's a screenshot of them:

I'm going to undeploy the changes now since you ran the audit and made a screenshot.