Skip to content

Commit cab75df

Browse files
committed
Fixed google map errors with caching and added some changed to environment variables to hide api key
1 parent 51904be commit cab75df

File tree

3 files changed

+51
-33
lines changed

3 files changed

+51
-33
lines changed

app/app/Http/Controllers/HomeController.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,13 @@ public function index(Request $request)
3737
'default_location' => BaseUser::getDefaultLocation(),
3838
'google_map_api_key' => config('app.google_map_api_key'),
3939
'turn_off_maps' => config('app.turn_off_maps'),
40-
'location_search_options' => $location_search_options
40+
'location_search_options' => $location_search_options,
41+
'firebase_api_key' => config('app.firebase_api_key'),
42+
'firebase_auth_domain' => config('app.firebase_auth_domain'),
43+
'firebase_database_url' => config('app.firebase_database_url'),
44+
'firebase_project_id' => config('app.firebase_project_id'),
45+
'firebase_storage_bucket' => config('app.firebase_storage_bucket'),
46+
'firebase_messaging_sender_id' => config('firebase_messaging_sender_id')
4147
]);
4248
}
4349

app/config/app.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,16 @@
118118

119119
'cipher' => 'AES-256-CBC',
120120

121+
/* Firebase keys
122+
| Will be used for push notifications
123+
*/
124+
'firebase_api_key' => env('FIREBASE_API_KEY', ''),
125+
'firebase_auth_domain'=> env('FIREBASE_AUTH_DOMAIN', ''),
126+
'firebase_database_url' => env('FIREBASE_DATABASE_URL, '),
127+
'firebase_project_id' => env('FIREBASE_PROJECT_ID', ''),
128+
'firebase_storage_bucket' => env('FIREBASE_STOREAGE_BUCKET', ''),
129+
'firebase_messaging_sender_id' => env('FIREBASE_MESSAGING_SENDER_ID', ''),
130+
121131
/*
122132
|--------------------------------------------------------------------------
123133
| Logging Configuration

app/public/service-worker.js

Lines changed: 34 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -40,37 +40,39 @@ self.addEventListener('activate', function(e) {
4040
})
4141

4242
self.addEventListener('fetch',function(e) {
43-
e.respondWith(
44-
45-
caches.match(e.request)
46-
47-
48-
.then(function(response) {
49-
50-
if (response) {
51-
return response;
52-
}
53-
54-
var requestClone = e.request.clone();
55-
return fetch(requestClone)
56-
.then(function(response) {
57-
58-
if (!response) {
59-
return response;
60-
}
61-
62-
var responseClone = response.clone();
63-
caches.open(cacheName).then(function(cache) {
64-
cache.put(e.request, responseClone);
65-
return response;
43+
44+
if (e.request.url.indexOf('https://maps.googleapi.com') !== 0 ||
45+
e.request.url.indexOf('http://maps.googleapis.com') !== 0) {
46+
e.respondWith(
47+
caches.match(e.request)
48+
.then(function(response) {
49+
50+
if (response) {
51+
return response;
52+
}
53+
54+
var requestClone = e.request.clone();
55+
return fetch(requestClone)
56+
.then(function(response) {
57+
58+
if (!response) {
59+
return response;
60+
}
61+
62+
var responseClone = response.clone();
63+
caches.open(cacheName).then(function(cache) {
64+
cache.put(e.request, responseClone)
65+
.catch(function(err) {
66+
console.log('Post Request Made', err);
67+
});
68+
return response;
69+
});
70+
71+
})
72+
.catch(function(err) {
73+
console.log('[ServiceWorker] Error Fetching & Caching New Data', err);
6674
});
67-
68-
})
69-
.catch(function(err) {
70-
console.log('[ServiceWorker] Error Fetching & Caching New Data', err);
71-
});
72-
73-
74-
})
75-
);
75+
})
76+
);
77+
}
7678
})

0 commit comments

Comments
 (0)