Skip to content

Commit 4f0cce9

Browse files
change it
1 parent ccbd7f7 commit 4f0cce9

File tree

1 file changed

+48
-78
lines changed

1 file changed

+48
-78
lines changed

packages/flutter/test/widgets/grid_view_test.dart

Lines changed: 48 additions & 78 deletions
Original file line numberDiff line numberDiff line change
@@ -932,50 +932,35 @@ void main() {
932932

933933
expect(sliverGridRegularTileLayout.childMainAxisExtent, 0);
934934

935-
double mainAxisExtent = 100;
936-
await tester.pumpWidget(Directionality(
937-
textDirection: TextDirection.ltr,
938-
child: GridView.builder(
939-
gridDelegate: SliverGridDelegateWithFixedCrossAxisCount(
940-
crossAxisCount: 3,
941-
mainAxisSpacing: 8,
942-
crossAxisSpacing: 8,
943-
mainAxisExtent: mainAxisExtent,
935+
Widget build(double mainAxisExtent) {
936+
return Directionality(
937+
textDirection: TextDirection.ltr,
938+
child: GridView.builder(
939+
gridDelegate: SliverGridDelegateWithFixedCrossAxisCount(
940+
crossAxisCount: 3,
941+
mainAxisSpacing: 8,
942+
crossAxisSpacing: 8,
943+
mainAxisExtent: mainAxisExtent,
944+
),
945+
itemBuilder: (BuildContext context, int index) {
946+
return Container(
947+
height: 50,
948+
alignment: Alignment.center,
949+
child: Text('$index'),
950+
);
951+
},
952+
itemCount: 50,
944953
),
945-
itemBuilder: (BuildContext context, int index) {
946-
return Container(
947-
height: 50,
948-
alignment: Alignment.center,
949-
child: Text('$index'),
950-
);
951-
},
952-
itemCount: 50,
953-
),
954-
));
954+
);
955+
}
956+
957+
double mainAxisExtent = 100;
958+
await tester.pumpWidget(build(mainAxisExtent));
955959

956960
expect(tester.takeException(), isNull);
957961

958962
mainAxisExtent = -100;
959-
await tester.pumpWidget(Directionality(
960-
textDirection: TextDirection.ltr,
961-
child: GridView.builder(
962-
gridDelegate: SliverGridDelegateWithFixedCrossAxisCount(
963-
crossAxisCount: 3,
964-
mainAxisSpacing: 8,
965-
crossAxisSpacing: 8,
966-
mainAxisExtent: mainAxisExtent,
967-
),
968-
itemBuilder: (BuildContext context, int index) {
969-
return Container(
970-
height: 50,
971-
alignment: Alignment.center,
972-
child: Text('$index'),
973-
);
974-
},
975-
itemCount: 50,
976-
),
977-
));
978-
await tester.pump();
963+
await tester.pumpWidget(build(mainAxisExtent));
979964

980965
expect(tester.takeException(), isNull);
981966
});
@@ -1012,50 +997,35 @@ void main() {
1012997

1013998
expect(sliverGridRegularTileLayout.childMainAxisExtent, 0);
1014999

1015-
double mainAxisExtent = 100;
1016-
await tester.pumpWidget(Directionality(
1017-
textDirection: TextDirection.ltr,
1018-
child: GridView.builder(
1019-
gridDelegate: SliverGridDelegateWithMaxCrossAxisExtent(
1020-
maxCrossAxisExtent: 100,
1021-
mainAxisSpacing: 8,
1022-
crossAxisSpacing: 8,
1023-
mainAxisExtent: mainAxisExtent,
1000+
Widget build(double mainAxisExtent) {
1001+
return Directionality(
1002+
textDirection: TextDirection.ltr,
1003+
child: GridView.builder(
1004+
gridDelegate: SliverGridDelegateWithMaxCrossAxisExtent(
1005+
maxCrossAxisExtent: 100,
1006+
mainAxisSpacing: 8,
1007+
crossAxisSpacing: 8,
1008+
mainAxisExtent: mainAxisExtent,
1009+
),
1010+
itemBuilder: (BuildContext context, int index) {
1011+
return Container(
1012+
height: 50,
1013+
alignment: Alignment.center,
1014+
child: Text('$index'),
1015+
);
1016+
},
1017+
itemCount: 50,
10241018
),
1025-
itemBuilder: (BuildContext context, int index) {
1026-
return Container(
1027-
height: 50,
1028-
alignment: Alignment.center,
1029-
child: Text('$index'),
1030-
);
1031-
},
1032-
itemCount: 50,
1033-
),
1034-
));
1019+
);
1020+
}
1021+
1022+
double mainAxisExtent = 100;
1023+
await tester.pumpWidget(build(mainAxisExtent));
10351024

10361025
expect(tester.takeException(), isNull);
10371026

10381027
mainAxisExtent = -100;
1039-
await tester.pumpWidget(Directionality(
1040-
textDirection: TextDirection.ltr,
1041-
child: GridView.builder(
1042-
gridDelegate: SliverGridDelegateWithMaxCrossAxisExtent(
1043-
maxCrossAxisExtent: 100,
1044-
mainAxisSpacing: 8,
1045-
crossAxisSpacing: 8,
1046-
mainAxisExtent: mainAxisExtent,
1047-
),
1048-
itemBuilder: (BuildContext context, int index) {
1049-
return Container(
1050-
height: 50,
1051-
alignment: Alignment.center,
1052-
child: Text('$index'),
1053-
);
1054-
},
1055-
itemCount: 50,
1056-
),
1057-
));
1058-
await tester.pump();
1028+
await tester.pumpWidget(build(mainAxisExtent));
10591029

10601030
expect(tester.takeException(), isNull);
10611031
});

0 commit comments

Comments
 (0)