Skip to content

Commit 042d57d

Browse files
Merge branch 'fix/gridview_delegate' of https://github.com/hello-coder-xu/flutter into fix/gridview_delegate
* 'fix/gridview_delegate' of https://github.com/hello-coder-xu/flutter: (162 commits) add gridview children view fix gridview delegate mainAxisExtent Enable TapRegion to detect all mouse button click (flutter#136799) [flutter_tools] build ios-frameworks: option to exclude plugin frameworks from the build (flutter#129739) Roll Flutter Engine from b87c1b32d55f to eee8aeb953df (1 revision) (flutter#139495) Add Impeller complex layout impeller benchmarks. (flutter#139490) Roll Flutter Engine from cf122461e94a to b87c1b32d55f (3 revisions) (flutter#139491) Remove InkSparkle.constantTurbulenceSeedSplashFactory usage (flutter#139481) Roll Packages from bc72d15 to 5d9874f (9 revisions) (flutter#139480) Roll Flutter Engine from cc9a72b692fc to cf122461e94a (1 revision) (flutter#139468) Roll Flutter Engine from 69cbf87f33c9 to cc9a72b692fc (1 revision) (flutter#139466) Roll Flutter Engine from 05e7f462048b to 69cbf87f33c9 (1 revision) (flutter#139453) Roll Flutter Engine from e782ab139ef2 to 05e7f462048b (1 revision) (flutter#139439) Roll Flutter Engine from 80a2fd76fd64 to e782ab139ef2 (1 revision) (flutter#139437) Roll Flutter Engine from 7ff24be43a36 to 80a2fd76fd64 (1 revision) (flutter#139436) Roll Flutter Engine from cfabe42bc0c6 to 7ff24be43a36 (1 revision) (flutter#139433) Roll Flutter Engine from f0122c32c5cc to cfabe42bc0c6 (1 revision) (flutter#139423) Roll Flutter Engine from f23c33f3831c to f0122c32c5cc (1 revision) (flutter#139422) Roll Flutter Engine from d441f087052c to f23c33f3831c (2 revisions) (flutter#139421) Roll Flutter Engine from 27d37db84b8e to d441f087052c (1 revision) (flutter#139419) ...
2 parents f6a781f + f3161c6 commit 042d57d

File tree

253 files changed

+6839
-1954
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

253 files changed

+6839
-1954
lines changed

.ci.yaml

Lines changed: 75 additions & 74 deletions
Large diffs are not rendered by default.

.github/dependabot.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ updates:
1414
- "yusuf-goog"
1515
labels:
1616
- "team"
17-
- "team: infra"
17+
- "team-infra"
1818
- "autosubmit"
1919
- package-ecosystem: "docker"
2020
directory: "/dev/ci/docker_linux"
@@ -26,7 +26,7 @@ updates:
2626
- "christopherfujino"
2727
labels:
2828
- "team"
29-
- "team: infra"
29+
- "team-infra"
3030
- "autosubmit"
3131
- package-ecosystem: "github-actions"
3232
directory: "/"
@@ -36,5 +36,5 @@ updates:
3636
- "godofredoc"
3737
labels:
3838
- "team"
39-
- "team: infra"
39+
- "team-infra"
4040
- "autosubmit"

.github/workflows/lock.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
runs-on: ubuntu-latest
1919
if: ${{ github.repository == 'flutter/flutter' }}
2020
steps:
21-
- uses: dessant/lock-threads@d42e5f49803f3c4e14ffee0378e31481265dda22
21+
- uses: dessant/lock-threads@1bf7ec25051fe7c00bdd17e6a7cf3d7bfb7dc771
2222
with:
2323
process-only: 'issues'
2424
github-token: ${{ github.token }}

TESTOWNERS

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,8 @@
104104
/dev/devicelab/bin/tasks/draw_atlas_perf__timeline_summary.dart @jonahwilliams @flutter/engine
105105
/dev/devicelab/bin/tasks/static_path_tessellation_perf__timeline_summary.dart @jonahwilliams @flutter/engine
106106
/dev/devicelab/bin/tasks/dynamic_path_tessellation_perf__timeline_summary.dart @jonahwilliams @flutter/engine
107+
/dev/devicelab/bin/tasks/complex_layout_scroll_perf_impeller__timeline_summary.dart @jonahwilliams @flutter/engine
108+
/dev/devicelab/bin/tasks/complex_layout_scroll_perf_impeller_gles__timeline_summary.dart @jonahwilliams @flutter/engine
107109

108110
## Windows Android DeviceLab tests
109111
/dev/devicelab/bin/tasks/basic_material_app_win__compile.dart @zanderso @flutter/tool
@@ -295,12 +297,8 @@
295297
/dev/devicelab/bin/tasks/windows_startup_test.dart @loic-sharma @flutter/desktop
296298

297299
## Host only framework tests
298-
# Linux analyze
299-
/dev/bots/analyze.dart @HansMuller @flutter/framework
300-
# Linux/Mac/Windows customer_testing
301-
/dev/customer_testing/run_tests.dart @HansMuller @flutter/framework
302-
# Linux docs
303-
# Linux docs_test
300+
# Linux docs_deploy_beta
301+
# Linux docs_deploy_stable
304302
# Linux docs_publish
305303
/dev/bots/docs.sh @HansMuller @flutter/framework
306304
# Linux packages_autoroller
@@ -323,13 +321,17 @@
323321
# TODO(keyonghan): add files/paths for below framework host only testss.
324322
# https://github.com/flutter/flutter/issues/82068
325323
#
324+
# analyze @HansMuller @flutter/framework
326325
# build_tests @eliasyishak @flutter/tool
327326
# ci_yaml flutter roller @caseyhillers @flutter/infra
328327
# coverage @godofredoc @flutter/infra
328+
# customer_testing @HansMuller @flutter/framework
329+
# docs @HansMuller @flutter/framework
329330
# flutter_packaging @godofredoc @flutter/infra
330331
# flutter_plugins @stuartmorgan @flutter/plugin
331332
# framework_tests @HansMuller @flutter/framework
332333
# fuchsia_precache @christopherfujino @flutter/tool
334+
# realm_checker @jacksongardner @flutter/tool
333335
# skp_generator @Hixie
334336
# test_ownership @keyonghan
335337
# tool_host_cross_arch_tests @andrewkolos @flutter/tool
@@ -341,4 +343,3 @@
341343
# web_long_running_tests @yjbanov @flutter/web
342344
# web_tests @yjbanov @flutter/web
343345
# web_tool_tests @eliasyishak @flutter/tool
344-
# realm_checker @jacksongardner @flutter/tool

bin/internal/engine.version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
dda2499df48a097aa44719b7cd0f7410eee6292a
1+
eee8aeb953dfc4c7f47730582c90e84556e7974f
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
c9933fc09a0bb3790def393105f984ad24a2029a
1+
5d9874f69bcefa4b9970bde72a563d77bdb65d5e

bin/internal/fuchsia-linux.version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
IK4xyRtZkDwqT6pXAFvX-JUnOhqlqASQWGy3ecKGdesC
1+
CGyrUgA1M1yFx5N5C1aFQ_Q4Y5uP_FhxctN_UCZ9BugC

dev/benchmarks/complex_layout/test/measure_scroll_smoothness.dart

Lines changed: 14 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -68,40 +68,28 @@ class ResampleFlagVariant extends TestVariant<TestScenario> {
6868

6969
late TestScenario currentValue;
7070
bool get resample {
71-
switch (currentValue) {
72-
case TestScenario.resampleOn90Hz:
73-
case TestScenario.resampleOn59Hz:
74-
return true;
75-
case TestScenario.resampleOff90Hz:
76-
case TestScenario.resampleOff59Hz:
77-
return false;
78-
}
71+
return switch (currentValue) {
72+
TestScenario.resampleOn90Hz || TestScenario.resampleOn59Hz => true,
73+
TestScenario.resampleOff90Hz || TestScenario.resampleOff59Hz => false,
74+
};
7975
}
8076
double get frequency {
81-
switch (currentValue) {
82-
case TestScenario.resampleOn90Hz:
83-
case TestScenario.resampleOff90Hz:
84-
return 90.0;
85-
case TestScenario.resampleOn59Hz:
86-
case TestScenario.resampleOff59Hz:
87-
return 59.0;
88-
}
77+
return switch (currentValue) {
78+
TestScenario.resampleOn90Hz || TestScenario.resampleOff90Hz => 90.0,
79+
TestScenario.resampleOn59Hz || TestScenario.resampleOff59Hz => 59.0,
80+
};
8981
}
9082

9183
Map<String, dynamic>? result;
9284

9385
@override
9486
String describeValue(TestScenario value) {
95-
switch (value) {
96-
case TestScenario.resampleOn90Hz:
97-
return 'resample on with 90Hz input';
98-
case TestScenario.resampleOn59Hz:
99-
return 'resample on with 59Hz input';
100-
case TestScenario.resampleOff90Hz:
101-
return 'resample off with 90Hz input';
102-
case TestScenario.resampleOff59Hz:
103-
return 'resample off with 59Hz input';
104-
}
87+
return switch (value) {
88+
TestScenario.resampleOn90Hz => 'resample on with 90Hz input',
89+
TestScenario.resampleOn59Hz => 'resample on with 59Hz input',
90+
TestScenario.resampleOff90Hz => 'resample off with 90Hz input',
91+
TestScenario.resampleOff59Hz => 'resample off with 59Hz input',
92+
};
10593
}
10694

10795
@override

dev/benchmarks/macrobenchmarks/lib/src/filtered_child_animation.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,12 @@ class _FilteredChildAnimationPageState extends State<FilteredChildAnimationPage>
6060
}
6161

6262
String get _title {
63-
switch (_filterType) {
64-
case FilterType.opacity: return 'Fading Child Animation';
65-
case FilterType.rotateTransform: return 'Transformed Child Animation';
66-
case FilterType.rotateFilter: return 'Matrix Filtered Child Animation';
67-
case null: return 'Static Child';
68-
}
63+
return switch (_filterType) {
64+
FilterType.opacity => 'Fading Child Animation',
65+
FilterType.rotateTransform => 'Transformed Child Animation',
66+
FilterType.rotateFilter => 'Matrix Filtered Child Animation',
67+
null => 'Static Child',
68+
};
6969
}
7070

7171
static Widget _makeChild(int rows, int cols, double fontSize, bool complex) {

dev/benchmarks/microbenchmarks/lib/gestures/velocity_tracker_bench.dart

Lines changed: 29 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
// found in the LICENSE file.
44

55
import 'package:flutter/gestures.dart';
6+
import 'package:flutter_test/flutter_test.dart';
67

78
import '../common.dart';
89
import 'data/velocity_tracker_data.dart';
@@ -16,38 +17,43 @@ class TrackerBenchmark {
1617
final String name;
1718
}
1819

19-
void main() {
20+
Future<void> main() async {
2021
assert(false, "Don't run benchmarks in debug mode! Use 'flutter run --release'.");
2122
final BenchmarkResultPrinter printer = BenchmarkResultPrinter();
2223
final List<TrackerBenchmark> benchmarks = <TrackerBenchmark>[
23-
TrackerBenchmark(name: 'velocity_tracker_iteration', tracker: VelocityTracker.withKind(PointerDeviceKind.touch)),
24-
TrackerBenchmark(name: 'velocity_tracker_iteration_ios_fling', tracker: IOSScrollViewFlingVelocityTracker(PointerDeviceKind.touch)),
24+
TrackerBenchmark(name: 'velocity_tracker_iteration',
25+
tracker: VelocityTracker.withKind(PointerDeviceKind.touch)),
26+
TrackerBenchmark(name: 'velocity_tracker_iteration_ios_fling',
27+
tracker: IOSScrollViewFlingVelocityTracker(PointerDeviceKind.touch)),
2528
];
2629
final Stopwatch watch = Stopwatch();
2730

28-
for (final TrackerBenchmark benchmark in benchmarks) {
29-
print('${benchmark.name} benchmark...');
30-
final VelocityTracker tracker = benchmark.tracker;
31-
watch.reset();
32-
watch.start();
33-
for (int i = 0; i < _kNumIters; i += 1) {
34-
for (final PointerEvent event in velocityEventData) {
35-
if (event is PointerDownEvent || event is PointerMoveEvent) {
36-
tracker.addPosition(event.timeStamp, event.position);
37-
}
38-
if (event is PointerUpEvent) {
39-
tracker.getVelocity();
31+
await benchmarkWidgets((WidgetTester tester) async {
32+
for (final TrackerBenchmark benchmark in benchmarks) {
33+
print('${benchmark.name} benchmark...');
34+
final VelocityTracker tracker = benchmark.tracker;
35+
watch.reset();
36+
watch.start();
37+
for (int i = 0; i < _kNumIters; i += 1) {
38+
for (final PointerEvent event in velocityEventData) {
39+
if (event is PointerDownEvent || event is PointerMoveEvent) {
40+
tracker.addPosition(event.timeStamp, event.position);
41+
}
42+
if (event is PointerUpEvent) {
43+
tracker.getVelocity();
44+
}
4045
}
4146
}
47+
watch.stop();
48+
49+
printer.addResult(
50+
description: 'Velocity tracker: ${tracker.runtimeType}',
51+
value: watch.elapsedMicroseconds / _kNumIters,
52+
unit: 'µs per iteration',
53+
name: benchmark.name,
54+
);
4255
}
43-
watch.stop();
44-
printer.addResult(
45-
description: 'Velocity tracker: ${tracker.runtimeType}',
46-
value: watch.elapsedMicroseconds / _kNumIters,
47-
unit: 'µs per iteration',
48-
name: benchmark.name,
49-
);
50-
}
56+
});
5157

5258
printer.printToStdout();
5359
}

0 commit comments

Comments
 (0)