Merge pull request #244 from darosior/redundant_ascii_check

miniscript: remove a redundant check for non-ASCII chars

Author: heap-coder

src/miniscript/mod.rs

@@ -308,12 +308,7 @@ impl<Pk: MiniscriptKey, Ctx: ScriptContext> Miniscript<Pk, Ctx> {
         <Pk as str::FromStr>::Err: ToString,
         <<Pk as MiniscriptKey>::Hash as str::FromStr>::Err: ToString,
     {
-        for ch in s.as_bytes() {
-            if *ch < 20 || *ch > 127 {
-                return Err(Error::Unprintable(*ch));
-            }
-        }
-
+        // This checks for invalid ASCII chars
         let top = expression::Tree::from_str(s)?;
         let ms: Miniscript<Pk, Ctx> = expression::FromTree::from_tree(&top)?;
 
@@ -898,4 +893,12 @@ mod tests {
         ))
         .is_err());
     }
+
+    #[test]
+    fn non_ascii() {
+        assert!(Segwitv0Script::from_str_insane("🌏")
+            .unwrap_err()
+            .to_string()
+            .contains("unprintable character"));
+    }
 }