Merge rust-bitcoin/rust-miniscript#352: Allow direct compilation of a Policy into a valid Descriptor

169d8498567e33b5ccf9ff37788884538914c72d Add policy to descriptor target compilation method (Aman Rojjha)

Pull request description:

  This PR works on top of  #291 and #342. It introduces a new function `compile_to_descriptor` which requires a `DescriptorCtx` (suggestions for a better enum name are welcome!) allowing directly compilation of a policy into the specified descriptor type.

ACKs for top commit:
  apoelstra:
    ACK 169d8498567e33b5ccf9ff37788884538914c72d
  sanket1729:
    ACK 169d8498567e33b5ccf9ff37788884538914c72d

Tree-SHA512: 0f895f4774ea4f56db76280ac756df616a70e5d7d60cc128f9a050ef86658f786b2d45885d748dba51751146a6e93b3731f4ae193b7d80284ffaea20be1e8f92

Author: heap-coder

src/policy/concrete.rs

@@ -100,6 +100,21 @@ pub enum PolicyError {
     DuplicatePubKeys,
 }
 
+/// Descriptor context for [`Policy`] compilation into a [`Descriptor`]
+pub enum DescriptorCtx<Pk> {
+    /// [Bare][`Descriptor::Bare`]
+    Bare,
+    /// [Sh][`Descriptor::Sh`]
+    Sh,
+    /// [Wsh][`Descriptor::Wsh`]
+    Wsh,
+    /// Sh-wrapped [Wsh][`Descriptor::Wsh`]
+    ShWsh,
+    /// [Tr][`Descriptor::Tr`] where the Option<Pk> corresponds to the internal_key if no internal
+    /// key can be inferred from the given policy
+    Tr(Option<Pk>),
+}
+
 impl fmt::Display for PolicyError {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
         match *self {
@@ -289,6 +304,31 @@ impl<Pk: MiniscriptKey> Policy<Pk> {
         }
     }
 
+    /// Compile the [`Policy`] into desc_ctx [`Descriptor`]
+    ///
+    /// In case of [Tr][`DescriptorCtx::Tr`], `internal_key` is used for the Taproot comilation when
+    /// no public key can be inferred from the given policy
+    #[cfg(feature = "compiler")]
+    pub fn compile_to_descriptor<Ctx: ScriptContext>(
+        &self,
+        desc_ctx: DescriptorCtx<Pk>,
+    ) -> Result<Descriptor<Pk>, Error> {
+        self.is_valid()?;
+        match self.is_safe_nonmalleable() {
+            (false, _) => Err(Error::from(CompilerError::TopLevelNonSafe)),
+            (_, false) => Err(Error::from(
+                CompilerError::ImpossibleNonMalleableCompilation,
+            )),
+            _ => match desc_ctx {
+                DescriptorCtx::Bare => Descriptor::new_bare(compiler::best_compilation(self)?),
+                DescriptorCtx::Sh => Descriptor::new_sh(compiler::best_compilation(self)?),
+                DescriptorCtx::Wsh => Descriptor::new_wsh(compiler::best_compilation(self)?),
+                DescriptorCtx::ShWsh => Descriptor::new_sh_wsh(compiler::best_compilation(self)?),
+                DescriptorCtx::Tr(unspendable_key) => self.compile_tr(unspendable_key),
+            },
+        }
+    }
+
     /// Compile the descriptor into an optimized `Miniscript` representation
     #[cfg(feature = "compiler")]
     pub fn compile<Ctx: ScriptContext>(&self) -> Result<Miniscript<Pk, Ctx>, CompilerError> {