-
Notifications
You must be signed in to change notification settings - Fork 714
ci: Fix quick-jobs GHC version to 9.6 #10043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Rodrigo Mesquita <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, thanks.
Oh my, one of quick jobs is failing now in the actual check: https://github.com/haskell/cabal/actions/runs/9193944143/job/25286198767?pr=10043 Anyone has ideas what's going on? |
Extraneous parenthesis gets dropped: - = Z {zPackages :: ([ZPackage]),
- zTools :: ([ZTool]),
+ = Z {zPackages :: [ZPackage],
+ zTools :: [ZTool], |
that's interesting... why does it pass on |
No idea, but indeed the parentheses are extraneous, and should be removed anyway. |
@Mikolaj ideas? |
I forgot what this test does. If it passes on master, does it mean a backport that fixes it on master is missing? |
The test does this: cabal/.github/workflows/quick-jobs.yml Lines 52 to 60 in c6b2f1f
|
And the missing backport is #10041. You are welcome. :) |
Manual backport of #10026 . Other backports are stuck with red CI until this one is landed.
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: