Skip to content

ci: Fix quick-jobs GHC version to 9.6 #10043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

ulysses4ever
Copy link
Collaborator

@ulysses4ever ulysses4ever commented May 22, 2024

Manual backport of #10026 . Other backports are stuck with red CI until this one is landed.


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Copy link
Member

@Kleidukos Kleidukos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks.

@ulysses4ever
Copy link
Collaborator Author

Oh my, one of quick jobs is failing now in the actual check: https://github.com/haskell/cabal/actions/runs/9193944143/job/25286198767?pr=10043

Anyone has ideas what's going on?

@Kleidukos
Copy link
Member

Extraneous parenthesis gets dropped:

-    = Z {zPackages :: ([ZPackage]),
-         zTools :: ([ZTool]),
+    = Z {zPackages :: [ZPackage],
+         zTools :: [ZTool],

@ulysses4ever
Copy link
Collaborator Author

that's interesting... why does it pass on master?..

@Kleidukos
Copy link
Member

No idea, but indeed the parentheses are extraneous, and should be removed anyway.

@ulysses4ever
Copy link
Collaborator Author

@Mikolaj ideas?

@Mikolaj
Copy link
Member

Mikolaj commented May 22, 2024

I forgot what this test does. If it passes on master, does it mean a backport that fixes it on master is missing?

@Mikolaj
Copy link
Member

Mikolaj commented May 23, 2024

The test does this:

- name: Regenerate files
run: |
make -B lexer
make -B spdx
make -B templates
- name: Check that diff is clean
run: |
git status > /dev/null
git diff-files -p --exit-code

@Mikolaj
Copy link
Member

Mikolaj commented May 23, 2024

And the missing backport is #10041.

You are welcome. :)

@ulysses4ever ulysses4ever merged commit ae8776e into 3.12 May 23, 2024
@ulysses4ever ulysses4ever deleted the ulysses4ever/bp/3.12/pr-10026 branch May 23, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants