- Corrected the condition in the validate_fields helper function in the Gated Marketplace pallet. Changed the condition to trigger the FieldsNotProvided error when fields are empty and custodian_fields are None, ensuring that the fields are provided when necessary.

- Performed a minor clean-up in mock.rs, removing an unnecessary import of `RawOrigin` from the `frame_system` crate. This change promotes better code hygiene and optimizes imports.

Author: didiermis

pallets/gated-marketplace/src/functions.rs

@@ -806,7 +806,7 @@ impl<T: Config> Pallet<T> {
 				}
 			}
 			None => {
-				if !fields.is_empty() {
+				if fields.is_empty() {
 					return Err(Error::<T>::FieldsNotProvided.into())
 				}
 			}

pallets/gated-marketplace/src/mock.rs

@@ -1,5 +1,4 @@
 use crate as pallet_gated_marketplace;
-use frame_system::RawOrigin;
 use sp_runtime::traits::Lookup;
 
 use frame_support::{
@@ -22,6 +21,7 @@ use sp_runtime::{
 use system::EnsureSigned;
 type AccountId = u64;
 type AssetId = u32;
+
 // Configure a mock runtime to test the pallet.
 frame_support::construct_runtime!(
   pub enum Test

pallets/gated-marketplace/src/tests.rs

@@ -378,6 +378,7 @@ fn apply_twice_shouldnt_work() {
 			1,
 		));
 		let m_id = get_marketplace_id("my marketplace", 500, 600, 1);
+		
 		assert_ok!(GatedMarketplace::apply(
 			RuntimeOrigin::signed(3),
 			m_id,