BUG/MINOR: removed memory leaks if no HTTP requests are mirrored

zaga00 · zaga00 · commit 379daa2868f2 · 2020-02-21T14:36:22.000+01:00
In case the program was compiled to use the cURL library and we did not
specify a mirror url at program startup, the memory allocated for mirroring
HTTP requests was not freed.

Version of the program changed to v1.2.6.
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-1.2.5
+1.2.6
diff --git a/src/.build-counter b/src/.build-counter
@@ -1 +1 @@
-2387
+2388
diff --git a/src/spoa-message.c b/src/spoa-message.c
@@ -430,8 +430,12 @@ int spoa_msg_mirror(struct spoe_frame *frame, const char **buf, const char *end)
 		}
 	}
 
-	if (_ERROR(retval))
+	if (_ERROR(retval) || _NULL(cfg.mir_url))
 		mir_ptr_free(&mir);
+
+#else
+
+	mir_ptr_free(&mir);
 #endif /* HAVE_LIBCURL */
 
 	SPOE_BUFFER_ADVANCE(retval);

Original file line number	Diff line number	Diff line change
`@@ -430,8 +430,12 @@ int spoa_msg_mirror(struct spoe_frame frame, const char buf, const char end)`
`430`	`430`	`}`
`431`	`431`	`}`
`432`	`432`
`433`		`- if (_ERROR(retval))`
	`433`	`+ if (_ERROR(retval) \|\| _NULL(cfg.mir_url))`
`434`	`434`	`mir_ptr_free(&mir);`
	`435`	`+`
	`436`	`+#else`
	`437`	`+`
	`438`	`+ mir_ptr_free(&mir);`
`435`	`439`	`#endif /* HAVE_LIBCURL */`
`436`	`440`
`437`	`441`	`SPOE_BUFFER_ADVANCE(retval);`