Speed regression after f32be2b (MacOS X)

[NikolayMurha]

Hello

I have a speed regression.
Rendering does not keep up with actual data acquisition. If you press Disconnect, the plotter can draw for a few more minutes.
I tried to compile commit by commit, and found that the speed reduction occurs after the commit f32be2b.

Unfortunately, I don't know rust at all, and it's hard for me to understand what the problem is.

MacOS X 15.3.1
Serial Baudrate 115200
Thank you!

[hacknus]

Thanks for bringing this up!
This might be realted to #112

I thought that is only an issue on Windows, but it seems that you also have this problem on macOS. Can you tell me what the device you connect to is sending out and in what time-interval?

Is f32be2b the last working commit? or is this already breaking it?

[hacknus]

Yeah, ok, I see it now! Thanks for pointing out the commit!

Trying a fix here: https://github.com/hacknus/serial-monitor-rust/tree/fix-sample-rate-issue

[NikolayMurha]

f32be2b already breaking it.
I read some sensor with 200Hz frequency and send 4 uint32 to serial.

When look at the log I can see with the naked eye that the time in the log are passing much slower than they actually are.

log:

[RECV] t + 1.866s: 6625,4710,3975,9048
[RECV] t + 1.871s: 6640,4810,3960,9105
[RECV] t + 1.876s: 6405,4775,3812,8851
[RECV] t + 1.881s: 6462,4780,3950,8955
[RECV] t + 1.886s: 6502,4840,3842,8970
[RECV] t + 1.891s: 6385,4775,3787,8826
[RECV] t + 1.896s: 6435,4680,3817,8825
[RECV] t + 1.901s: 6580,4790,3867,9010
[RECV] t + 1.906s: 6537,4865,3817,8998
[RECV] t + 1.911s: 6532,4765,3827,8945
[RECV] t + 1.916s: 6507,4760,3905,8958
[RECV] t + 1.920s: 6625,4850,3960,9115
[RECV] t + 1.926s: 6492,4790,3837,8933
[RECV] t + 1.930s: 6610,4800,3925,9062
[RECV] t + 1.935s: 6537,4720,3877,8946
[RECV] t + 1.940s: 6562,4885,3950,9084
[RECV] t + 1.945s: 6537,4760,3807,8937
[RECV] t + 1.950s: 6620,4705,3885,9003
[RECV] t + 1.955s: 6610,4750,3660,8924
[RECV] t + 1.960s: 6687,4710,3727,8988
[RECV] t + 1.965s: 6615,4765,3872,9025
[RECV] t + 1.970s: 6640,4855,3697,9018
[RECV] t + 1.975s: 6430,4735,3872,8874
[RECV] t + 1.980s: 6440,4745,3960,8925
[RECV] t + 1.985s: 6467,4710,3940,8917
[RECV] t + 1.990s: 6400,4750,3867,8858
[RECV] t + 1.995s: 6425,4755,3857,8875

[hacknus]

Thanks, I'll have to do some further investigations later today, but I hope the update on the other branch should already improve it.

[NikolayMurha]

Yeah, ok, I see it now! Thanks for pointing out the commit!

Trying a fix here: https://github.com/hacknus/serial-monitor-rust/tree/fix-sample-rate-issue

I compiled locally and it works for me.
Thanks!

[hacknus]

Amazing, thanks a lot for the help here!

[hacknus]

fixed with #116