Fixes #3318. v1-MouseClick should be invoked only once on a mouse click.

Author: BDisp

Terminal.Gui/Core/View.cs

@@ -2894,9 +2894,14 @@ public virtual bool OnMouseEvent (MouseEvent mouseEvent)
 				return false;
 			}
 
-			var args = new MouseEventArgs (mouseEvent);
-			if (OnMouseClick (args))
-				return true;
+			if (mouseEvent.Flags.HasFlag (MouseFlags.Button1Clicked) || mouseEvent.Flags.HasFlag (MouseFlags.Button2Clicked)
+				|| mouseEvent.Flags.HasFlag (MouseFlags.Button3Clicked) || mouseEvent.Flags.HasFlag (MouseFlags.Button4Clicked)) {
+
+				var args = new MouseEventArgs (mouseEvent);
+				if (OnMouseClick (args)) {
+					return true;
+				}
+			}
 			if (MouseEvent (mouseEvent))
 				return true;
 

UnitTests/Views/ViewTests.cs

@@ -4581,5 +4581,19 @@ public void View_Instance_Use_Attribute_Normal_On_Draw ()
 011110
 000000", new Attribute [] { Colors.TopLevel.Normal, Colors.TopLevel.Focus });
 		}
+
+		[Fact]
+		public void OnMouseClick_Is_Only_Fired_Once ()
+		{
+			var mouseClicks = 0;
+			var view = new View ();
+			view.MouseClick += (_) => mouseClicks++;
+
+			view.OnMouseEvent (new MouseEvent () { Flags = MouseFlags.Button1Pressed });
+			view.OnMouseEvent (new MouseEvent () { Flags = MouseFlags.Button1Released });
+			view.OnMouseEvent (new MouseEvent () { Flags = MouseFlags.Button1Clicked });
+
+			Assert.Equal (1, mouseClicks);
+		}
 	}
 }