Skip to content

Commit dcd2f86

Browse files
Ethan NicholasSkia Commit-Bot
authored andcommitted
Reland "Reland "Reland "Reland "Revert "Initial land of SkSL DSL."""""
This reverts commit 4129b6b. Reason for revert: WASM breakage: https://task-driver.skia.org/td/UBRwnWYfbc5IwUWqtFMv Original change's description: > Revert "Reland "Reland "Reland "Revert "Initial land of SkSL DSL.""""" > > This reverts commit 346dd53. > > Change-Id: I93bb18438cc6c2ad43d058d6c3f95bcc65d0cea9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/343916 > Commit-Queue: Ethan Nicholas <[email protected]> > Reviewed-by: John Stiles <[email protected]> [email protected],[email protected],[email protected] # Not skipping CQ checks because this is a reland. Change-Id: If05145cf9d9c51f4c76fe523f6050a670b5da669 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/345169 Reviewed-by: Ethan Nicholas <[email protected]> Commit-Queue: John Stiles <[email protected]>
1 parent 74ebd7e commit dcd2f86

32 files changed

+87
-3005
lines changed

gn/sksl.gni

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,6 @@ skia_sksl_sources = [
5656
"$_src/sksl/SkSLUtil.h",
5757
"$_src/sksl/SkSLVMGenerator.cpp",
5858
"$_src/sksl/SkSLVMGenerator.h",
59-
"$_src/sksl/dsl/DSLBlock.cpp",
60-
"$_src/sksl/dsl/DSLExpression.cpp",
61-
"$_src/sksl/dsl/DSLStatement.cpp",
62-
"$_src/sksl/dsl/DSLType.cpp",
63-
"$_src/sksl/dsl/DSLVar.cpp",
64-
"$_src/sksl/dsl/DSL_core.cpp",
65-
"$_src/sksl/dsl/priv/DSLWriter.cpp",
6659
"$_src/sksl/ir/SkSLBinaryExpression.h",
6760
"$_src/sksl/ir/SkSLBlock.h",
6861
"$_src/sksl/ir/SkSLBoolLiteral.h",

gn/tests.gni

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,6 @@ tests_sources = [
264264
"$_tests/SkResourceCacheTest.cpp",
265265
"$_tests/SkRuntimeEffectTest.cpp",
266266
"$_tests/SkSLCross.cpp",
267-
"$_tests/SkSLDSLTest.cpp",
268267
"$_tests/SkSLFPTestbed.cpp",
269268
"$_tests/SkSLGLSLTestbed.cpp",
270269
"$_tests/SkSLInterpreterTest.cpp",

src/gpu/glsl/GrGLSLShaderBuilder.cpp

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313
#include "src/gpu/glsl/GrGLSLBlend.h"
1414
#include "src/gpu/glsl/GrGLSLColorSpaceXformHelper.h"
1515
#include "src/gpu/glsl/GrGLSLProgramBuilder.h"
16-
#include "src/sksl/dsl/DSL.h"
17-
#include "src/sksl/dsl/priv/DSLWriter.h"
1816

1917
GrGLSLShaderBuilder::GrGLSLShaderBuilder(GrGLSLProgramBuilder* program)
2018
: fProgramBuilder(program)
@@ -83,13 +81,6 @@ void GrGLSLShaderBuilder::emitFunctionPrototype(GrSLType returnType,
8381
this->functions().append(";\n");
8482
}
8583

86-
void GrGLSLShaderBuilder::codeAppend(SkSL::dsl::Statement stmt) {
87-
std::unique_ptr<SkSL::Statement> skslStmt = stmt.release();
88-
if (skslStmt) {
89-
this->codeAppend(skslStmt->description().c_str());
90-
}
91-
}
92-
9384
static inline void append_texture_swizzle(SkString* out, GrSwizzle swizzle) {
9485
if (swizzle != GrSwizzle::RGBA()) {
9586
out->appendf(".%s", swizzle.asString().c_str());

src/gpu/glsl/GrGLSLShaderBuilder.h

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,6 @@
1717

1818
#include <stdarg.h>
1919

20-
namespace SkSL {
21-
22-
namespace dsl {
23-
class DSLStatement;
24-
} // namespace dsl
25-
26-
} // namespace SkSL
27-
2820
class GrGLSLColorSpaceXformHelper;
2921

3022
/**
@@ -117,8 +109,6 @@ class GrGLSLShaderBuilder {
117109

118110
void codeAppend(const char* str, size_t length) { this->code().append(str, length); }
119111

120-
void codeAppend(SkSL::dsl::DSLStatement stmt);
121-
122112
void codePrependf(const char format[], ...) SK_PRINTF_LIKE(2, 3) {
123113
va_list args;
124114
va_start(args, format);

src/sksl/SkSLCFGGenerator.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -366,9 +366,6 @@ void CFGGenerator::addExpression(CFG& cfg, std::unique_ptr<Expression>* e, bool
366366
}
367367
break;
368368
}
369-
case Expression::Kind::kCodeString:
370-
SkDEBUGFAIL("shouldn't be able to receive kCodeString here");
371-
break;
372369
case Expression::Kind::kConstructor: {
373370
Constructor& c = e->get()->as<Constructor>();
374371
for (auto& arg : c.arguments()) {

src/sksl/SkSLCompiler.cpp

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1813,7 +1813,6 @@ std::unique_ptr<Program> Compiler::convertProgram(
18131813

18141814
bool Compiler::optimize(LoadedModule& module) {
18151815
SkASSERT(!fErrorCount);
1816-
const Program::Settings* oldSettings = fIRGenerator->fSettings;
18171816
Program::Settings settings;
18181817
fIRGenerator->fKind = module.fKind;
18191818
fIRGenerator->fSettings = &settings;
@@ -1838,7 +1837,6 @@ bool Compiler::optimize(LoadedModule& module) {
18381837
break;
18391838
}
18401839
}
1841-
fIRGenerator->fSettings = oldSettings;
18421840
return fErrorCount == 0;
18431841
}
18441842

@@ -2161,13 +2159,10 @@ void Compiler::error(int offset, String msg) {
21612159
fErrorText += "error: " + (pos.fLine >= 1 ? to_string(pos.fLine) + ": " : "") + msg + "\n";
21622160
}
21632161

2164-
String Compiler::errorText(bool showCount) {
2165-
if (showCount) {
2166-
this->writeErrorCount();
2167-
}
2162+
String Compiler::errorText() {
2163+
this->writeErrorCount();
21682164
fErrorCount = 0;
21692165
String result = fErrorText;
2170-
fErrorText = "";
21712166
return result;
21722167
}
21732168

src/sksl/SkSLCompiler.h

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,6 @@ class SkSLCompileBench;
4545

4646
namespace SkSL {
4747

48-
namespace dsl {
49-
class DSL;
50-
class DSLWriter;
51-
} // namespace dsl
52-
5348
class ByteCode;
5449
class ExternalValue;
5550
class IRGenerator;
@@ -183,7 +178,7 @@ class SK_API Compiler : public ErrorReporter {
183178

184179
void error(int offset, String msg) override;
185180

186-
String errorText(bool showCount = true);
181+
String errorText();
187182

188183
void writeErrorCount();
189184

@@ -310,8 +305,6 @@ class SK_API Compiler : public ErrorReporter {
310305

311306
friend class AutoSource;
312307
friend class ::SkSLCompileBench;
313-
friend class dsl::DSL;
314-
friend class dsl::DSLWriter;
315308
};
316309

317310
#if !defined(SKSL_STANDALONE) && SK_SUPPORT_GPU

src/sksl/SkSLDehydrator.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -279,9 +279,6 @@ void Dehydrator::write(const Expression* e) {
279279
this->writeU8(b.value());
280280
break;
281281
}
282-
case Expression::Kind::kCodeString:
283-
SkDEBUGFAIL("shouldn't be able to receive kCodeString here");
284-
break;
285282
case Expression::Kind::kConstructor: {
286283
const Constructor& c = e->as<Constructor>();
287284
this->writeCommand(Rehydrator::kConstructor_Command);

0 commit comments

Comments
 (0)