Skip to content

Commit 3d2cc2b

Browse files
gaaclarkegspencergoog
authored andcommitted
Temporarily disabled tests that were using latin and arabic characters (flutter#21971)
while we fix them.
1 parent baf16c5 commit 3d2cc2b

File tree

2 files changed

+14
-6
lines changed

2 files changed

+14
-6
lines changed

third_party/txt/src/utils/LinuxUtils.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,4 +38,7 @@
3838
#define FRIEND_TEST_LINUX_ONLY(SUITE, TEST_NAME) \
3939
FRIEND_TEST_LINUX_ONLY_EXPANDED(SUITE, DISABLE_TEST_LINUX(TEST_NAME))
4040
#endif // defined(__linux__)
41+
42+
#define LINUX_ONLY_DISABLED(TEST_NAME) DISABLED_##TEST_NAME
43+
4144
#endif // LINUX_UTILS_H

third_party/txt/tests/paragraph_unittests.cc

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3973,7 +3973,10 @@ TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(GetRectsForRangeCenterParagraph)) {
39733973
ASSERT_TRUE(Snapshot());
39743974
}
39753975

3976-
TEST_F(ParagraphTest, LINUX_ONLY(GetRectsForRangeParagraphNewlineLeftAlign)) {
3976+
// 10/19/20 Temporarily disabled tests while being they are being fixed.
3977+
// https://github.com/flutter/flutter/issues/68493
3978+
TEST_F(ParagraphTest,
3979+
LINUX_ONLY_DISABLED(GetRectsForRangeParagraphNewlineLeftAlign)) {
39773980
const char* text = "01234\n\nعab\naعلی\n";
39783981
auto icu_text = icu::UnicodeString::fromUTF8(text);
39793982
std::u16string u16_text(icu_text.getBuffer(),
@@ -4070,7 +4073,8 @@ TEST_F(ParagraphTest, LINUX_ONLY(GetRectsForRangeParagraphNewlineLeftAlign)) {
40704073
ASSERT_TRUE(Snapshot());
40714074
}
40724075

4073-
TEST_F(ParagraphTest, LINUX_ONLY(GetRectsForRangeParagraphNewlineRightAlign)) {
4076+
TEST_F(ParagraphTest,
4077+
LINUX_ONLY_DISABLED(GetRectsForRangeParagraphNewlineRightAlign)) {
40744078
const char* text = "01234\n\nعab\naعلی\n";
40754079
auto icu_text = icu::UnicodeString::fromUTF8(text);
40764080
std::u16string u16_text(icu_text.getBuffer(),
@@ -4168,7 +4172,7 @@ TEST_F(ParagraphTest, LINUX_ONLY(GetRectsForRangeParagraphNewlineRightAlign)) {
41684172
}
41694173

41704174
TEST_F(ParagraphTest,
4171-
LINUX_ONLY(GetRectsForRangeCenterParagraphNewlineCentered)) {
4175+
LINUX_ONLY_DISABLED(GetRectsForRangeCenterParagraphNewlineCentered)) {
41724176
const char* text = "01234\n\nعab\naعلی\n";
41734177
auto icu_text = icu::UnicodeString::fromUTF8(text);
41744178
std::u16string u16_text(icu_text.getBuffer(),
@@ -4264,8 +4268,9 @@ TEST_F(ParagraphTest,
42644268

42654269
ASSERT_TRUE(Snapshot());
42664270
}
4271+
42674272
TEST_F(ParagraphTest,
4268-
LINUX_ONLY(GetRectsForRangeParagraphNewlineRTLLeftAlign)) {
4273+
LINUX_ONLY_DISABLED(GetRectsForRangeParagraphNewlineRTLLeftAlign)) {
42694274
const char* text = "01234\n\nعab\naعلی\n";
42704275
auto icu_text = icu::UnicodeString::fromUTF8(text);
42714276
std::u16string u16_text(icu_text.getBuffer(),
@@ -4363,7 +4368,7 @@ TEST_F(ParagraphTest,
43634368
}
43644369

43654370
TEST_F(ParagraphTest,
4366-
LINUX_ONLY(GetRectsForRangeParagraphNewlineRTLRightAlign)) {
4371+
LINUX_ONLY_DISABLED(GetRectsForRangeParagraphNewlineRTLRightAlign)) {
43674372
const char* text = "01234\n\nعab\naعلی\n";
43684373
auto icu_text = icu::UnicodeString::fromUTF8(text);
43694374
std::u16string u16_text(icu_text.getBuffer(),
@@ -4461,7 +4466,7 @@ TEST_F(ParagraphTest,
44614466
}
44624467

44634468
TEST_F(ParagraphTest,
4464-
LINUX_ONLY(GetRectsForRangeCenterParagraphNewlineRTLCentered)) {
4469+
LINUX_ONLY_DISABLED(GetRectsForRangeCenterParagraphNewlineRTLCentered)) {
44654470
const char* text = "01234\n\nعab\naعلی\n";
44664471
auto icu_text = icu::UnicodeString::fromUTF8(text);
44674472
std::u16string u16_text(icu_text.getBuffer(),

0 commit comments

Comments
 (0)