Skip to content

examples: Throw exception in test instead of printStackTrace #6521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2019
Merged

examples: Throw exception in test instead of printStackTrace #6521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions examples/src/test/java/io/grpc/examples/routeguide/RouteGuideServerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,8 @@ public void setUp() throws Exception {
}

@After
public void tearDown() {
try {
server.stop();
} catch (InterruptedException e) {
e.printStackTrace();
}
public void tearDown() throws Exception {
Copy link
Contributor

@sanjaypujare sanjaypujare Dec 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of points:

  • when Exception does happen, it will fail the test (before it would have passed). I think that's better but making sure that's what you want.

  • throws is wider than it needs to be (InterruptedException).

Copy link
Member Author

@ejona86 ejona86 Dec 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I want the test to fail. Yes, I purposefully used Exception, since that is pretty normal in tests since most exceptions should just cause the test to fail.

server.stop();
}

@Test
Expand Down