Skip to content

Commit cd875d9

Browse files
Update .NET 9 SDK and resolve warnings (#2502)
Co-authored-by: James Newton-King <[email protected]>
1 parent 540e87b commit cd875d9

File tree

29 files changed

+400
-46
lines changed

29 files changed

+400
-46
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ launchSettings.json
3434
BenchmarkDotNet.Artifacts/
3535
BDN.Generated/
3636
binaries/
37-
global.json
3837
.vscode/
3938
*.binlog
4039
build/feed

Directory.Packages.props

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<MicrosoftAspNetCoreAppPackageVersion>9.0.0-preview.5.24306.11</MicrosoftAspNetCoreAppPackageVersion>
55
<MicrosoftAspNetCoreApp8PackageVersion>8.0.6</MicrosoftAspNetCoreApp8PackageVersion>
66
<MicrosoftAspNetCoreApp7PackageVersion>7.0.5</MicrosoftAspNetCoreApp7PackageVersion>
7-
<MicrosoftAspNetCoreApp6PackageVersion>6.0.11</MicrosoftAspNetCoreApp6PackageVersion>
7+
<MicrosoftAspNetCoreApp6PackageVersion>6.0.33</MicrosoftAspNetCoreApp6PackageVersion>
88
<GrpcDotNetPackageVersion>2.63.0</GrpcDotNetPackageVersion>
99
<OpenTelemetryPackageVersion>1.6.0</OpenTelemetryPackageVersion>
1010
<OpenTelemetryIntergationPackageVersion>1.8.1</OpenTelemetryIntergationPackageVersion>
@@ -57,21 +57,20 @@
5757
<PackageVersion Include="OpenTelemetry.Instrumentation.Http" Version="$(OpenTelemetryIntergationPackageVersion)" />
5858

5959
<!-- Other -->
60-
<PackageVersion Include="BenchmarkDotNet" Version="0.13.1" />
60+
<PackageVersion Include="BenchmarkDotNet" Version="0.14.0" />
6161
<PackageVersion Include="CommandLineParser" Version="2.5.0" />
6262
<PackageVersion Include="Google.Api.CommonProtos" Version="2.15.0" />
63-
<PackageVersion Include="Google.Apis.Auth" Version="1.46.0" />
63+
<PackageVersion Include="Google.Apis.Auth" Version="1.68.0" />
6464
<PackageVersion Include="Google.Protobuf" Version="3.27.0" />
6565
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="6.0.0" />
6666
<PackageVersion Include="Microsoft.Build.Locator" Version="1.5.5" />
67-
<PackageVersion Include="Microsoft.Build" Version="16.9.0" />
67+
<PackageVersion Include="Microsoft.Build" Version="17.3.2" />
6868
<PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="9.0.0-preview.24216.2" />
6969
<PackageVersion Include="Microsoft.Crank.EventSources" Version="0.2.0-alpha.21255.1" />
70-
<PackageVersion Include="Microsoft.Extensions.Logging.Testing" Version="2.1.1" />
7170
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
7271
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="1.1.1" />
7372
<PackageVersion Include="Microsoft.Win32.Registry" Version="4.6.0" />
74-
<PackageVersion Include="Moq" Version="4.16.1" />
73+
<PackageVersion Include="Moq" Version="4.20.70" />
7574
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
7675
<PackageVersion Include="Nunit" Version="4.1.0" />
7776
<PackageVersion Include="NUnit3TestAdapter" Version="4.5.0" />
@@ -80,10 +79,9 @@
8079
<PackageVersion Include="System.CommandLine" Version="2.0.0-beta4.22272.1" />
8180
<PackageVersion Include="System.CommandLine.Rendering" Version="0.4.0-alpha.22272.1" />
8281
<PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="6.0.1" />
83-
<PackageVersion Include="System.IO.Pipelines" Version="5.0.1" />
8482
<PackageVersion Include="System.Memory" Version="4.5.3" />
8583
<PackageVersion Include="System.Net.Http.WinHttpHandler" Version="8.0.0" />
86-
<PackageVersion Include="System.Security.Principal.Windows" Version="4.7.0" />
84+
<PackageVersion Include="System.Security.Principal.Windows" Version="5.0.0" />
8785
<PackageVersion Include="System.Threading.Channels" Version="4.6.0" />
8886
</ItemGroup>
8987
</Project>

examples/Certifier/Client/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ static HttpClientHandler CreateHttpHandler(bool includeClientCertificate)
7373
// Load client certificate
7474
var basePath = Path.GetDirectoryName(typeof(Program).Assembly.Location);
7575
var certPath = Path.Combine(basePath!, "Certs", "client.pfx");
76-
var clientCertificate = new X509Certificate2(certPath, "1111");
76+
var clientCertificate = X509CertificateLoader.LoadPkcs12FromFile(certPath, "1111");
7777
handler.ClientCertificates.Add(clientCertificate);
7878
}
7979

examples/Container/Frontend/Frontend.csproj

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
1-
<Project Sdk="Microsoft.NET.Sdk.Web">
1+
<Project Sdk="Microsoft.NET.Sdk.Web">
22

33
<PropertyGroup>
44
<TargetFramework>net9.0</TargetFramework>
5+
<!-- Suppress obsolete error in code generated by Razor. -->
6+
<!-- CS0618: 'Router.PreferExactMatches' is obsolete: 'This property is obsolete and configuring it has not effect.' -->
7+
<NoWarn>$(NoWarn);CS0618</NoWarn>
58
</PropertyGroup>
69

710
<ItemGroup>

examples/Container/deploy.ps1

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
docker-compose -f .\docker-compose.yml build container-frontend
2-
docker-compose -f .\docker-compose.yml build container-backend
1+
docker compose -f .\docker-compose.yml build container-frontend
2+
docker compose -f .\docker-compose.yml build container-backend
33

44
kubectl delete -f .\Kubernetes\deploy-backend.yml
55
kubectl apply -f .\Kubernetes\deploy-backend.yml
66

77
kubectl delete -f .\Kubernetes\deploy-frontend.yml
8-
kubectl apply -f .\Kubernetes\deploy-frontend.yml
8+
kubectl apply -f .\Kubernetes\deploy-frontend.yml

global.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"sdk": {
3-
"version": "9.0.100-preview.5.24305.3",
3+
"version": "9.0.100-preview.7.24407.12",
44
"rollForward": "latestFeature"
55
}
66
}

grpcweb_interoptests.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ set -ex
1717

1818
echo "Starting gRPC-Web interop test containers"
1919

20-
docker-compose -f docker-compose.yml build grpcweb-server
21-
docker-compose -f docker-compose.yml build grpcweb-client
20+
docker compose -f docker-compose.yml build grpcweb-server
21+
docker compose -f docker-compose.yml build grpcweb-client
2222

23-
docker-compose -f docker-compose.yml up -d grpcweb-server
24-
docker-compose -f docker-compose.yml up -d grpcweb-client
23+
docker compose -f docker-compose.yml up -d grpcweb-server
24+
docker compose -f docker-compose.yml up -d grpcweb-client
2525

2626
sleep 5
2727

@@ -34,6 +34,6 @@ cd ../../..
3434

3535
echo "Remove all containers"
3636

37-
docker-compose down
37+
docker compose down
3838

39-
echo "gRPC-Web interop tests finished"
39+
echo "gRPC-Web interop tests finished"

perf/Grpc.AspNetCore.Microbenchmarks/Grpc.AspNetCore.Microbenchmarks.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
<FrameworkReference Include="Microsoft.AspNetCore.App" />
2626

2727
<PackageReference Include="BenchmarkDotNet" />
28-
<PackageReference Include="System.IO.Pipelines" />
2928
</ItemGroup>
3029

3130
</Project>

perf/benchmarkapps/GrpcClient/Program.cs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -476,11 +476,8 @@ private static ChannelBase CreateChannel(string target)
476476
{
477477
var basePath = Path.GetDirectoryName(AppContext.BaseDirectory);
478478
var certPath = Path.Combine(basePath!, "Certs", "client.pfx");
479-
var clientCertificate = new X509Certificate2(certPath, "1111");
480-
httpClientHandler.SslOptions.ClientCertificates = new X509CertificateCollection
481-
{
482-
clientCertificate
483-
};
479+
var clientCertificates = X509CertificateLoader.LoadPkcs12CollectionFromFile(certPath, "1111");
480+
httpClientHandler.SslOptions.ClientCertificates = clientCertificates;
484481
}
485482
#if NET5_0_OR_GREATER
486483
if (!string.IsNullOrEmpty(_options.UdsFileName))

test/FunctionalTests/Balancer/ConnectionTests.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,11 @@ Task<HelloReply> UnaryMethod(HelloRequest request, ServerCallContext context)
432432
// even after specifying the correct host override.
433433
var basePath = Path.GetDirectoryName(typeof(InProcessTestServer).Assembly.Location);
434434
var certPath = Path.Combine(basePath!, "localhost.pfx");
435+
#if NET9_0_OR_GREATER
436+
var cert = X509CertificateLoader.LoadPkcs12FromFile(certPath, "11111");
437+
#else
435438
var cert = new X509Certificate2(certPath, "11111");
439+
#endif
436440

437441
// Arrange
438442
using var endpoint1 = BalancerHelpers.CreateGrpcEndpoint<HelloRequest, HelloReply>(UnaryMethod, nameof(UnaryMethod), HttpProtocols.Http1AndHttp2, isHttps: true, certificate: cert);

0 commit comments

Comments
 (0)