code cleanup #1045
Merged
code cleanup #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 14, 2019 08:42
* changed all == to ===, != to !== (no unwanted side affect)
* shorten the test cases for all but first 2 instances than check for global vars * in some browser this can be a lot faster too (80% on Edge) https://jsperf.com/type-of-undefined-vs-undefined/30 * shorter notation. in some case just if (foo) as we should check for null as well (if there are not 0 number cases) ran all tests and demos. no issues.
latest bootstrap maks them flat (no border)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://jsperf.com/type-of-undefined-vs-undefined/30
(if there are not 0 number cases)
Checklist
yarn test)ran all tests and demos. no issues.