Skip to content

Commit 664624f

Browse files
committed
TS: fix to _gsEventHandler being null
1 parent 9a2eb39 commit 664624f

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

src/gridstack.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ export class GridStack {
128128
/** @internal */
129129
private _stylesId: string;
130130
/** @internal */
131-
private _gsEventHandler: {};
131+
private _gsEventHandler = {};
132132
/** @internal */
133133
private _styles: GridCSSStyleSheet;
134134
/** @internal */
@@ -816,7 +816,6 @@ export class GridStack {
816816
if (name === 'change' || name === 'added' || name === 'removed' || name === 'enable' || name === 'disable') {
817817
// native CustomEvent handlers - cash the generic handlers so we can easily remove
818818
let noData = (name === 'enable' || name === 'disable');
819-
this._gsEventHandler = this._gsEventHandler || {};
820819
if (noData) {
821820
this._gsEventHandler[name] = (event: Event) => callback(event);
822821
} else {
@@ -838,8 +837,6 @@ export class GridStack {
838837
* @param name of the event (see possible values)
839838
*/
840839
public off(name: GridStackEvent): GridStack {
841-
if (!this._gsEventHandler) return;
842-
843840
// check for array of names being passed instead
844841
if (name.indexOf(' ') !== -1) {
845842
let names = name.split(' ') as GridStackEvent[];
@@ -849,7 +846,7 @@ export class GridStack {
849846

850847
if (name === 'change' || name === 'added' || name === 'removed' || name === 'enable' || name === 'disable') {
851848
// remove native CustomEvent handlers
852-
if (this._gsEventHandler && this._gsEventHandler[name]) {
849+
if (this._gsEventHandler[name]) {
853850
this.el.removeEventListener(name, this._gsEventHandler[name]);
854851
}
855852
}

0 commit comments

Comments
 (0)