From 68a1744e3a05bdda35b271d1485f9a7cba4fe661 Mon Sep 17 00:00:00 2001 From: Benjie Gillam Date: Thu, 8 Apr 2021 08:53:05 +0100 Subject: [PATCH 1/3] Clarify type modifiers text --- spec/Section 4 -- Introspection.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/spec/Section 4 -- Introspection.md b/spec/Section 4 -- Introspection.md index 05fc17d61..8b5d1beea 100644 --- a/spec/Section 4 -- Introspection.md +++ b/spec/Section 4 -- Introspection.md @@ -218,12 +218,13 @@ enum __DirectiveLocation { ### The __Type Type `__Type` is at the core of the type introspection system, it represents all -types in the system: both named types (e.g. Scalars and Object types) and -type modifiers (e.g. List and Non-Null types). +types in the system: both named types (e.g. Scalars and Object types) and +type modifiers (e.g. List and Non-Null types). -Type modifiers are used to modify the type presented in the field `ofType`. -This modified type may recursively be a modified type, representing lists, -non-nullables, and combinations thereof, ultimately modifying a named type. +Type modifiers are used to modify the type presented in the `ofType` field (the +"inner type"). This inner type may recursively be a type modifier. In this way +type modifiers can represent lists, non-nullables, and combinations thereof, +ultimately modifying a named type. ### Type Kinds From b2532b165c4039d8f212f426fd04a0acfd6fd617 Mon Sep 17 00:00:00 2001 From: Benjie Gillam Date: Sun, 25 Apr 2021 16:03:12 +0100 Subject: [PATCH 2/3] Remove 'Type modifier' from the spec text --- spec/Section 4 -- Introspection.md | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/spec/Section 4 -- Introspection.md b/spec/Section 4 -- Introspection.md index 8b5d1beea..b3174f67c 100644 --- a/spec/Section 4 -- Introspection.md +++ b/spec/Section 4 -- Introspection.md @@ -219,12 +219,11 @@ enum __DirectiveLocation { `__Type` is at the core of the type introspection system, it represents all types in the system: both named types (e.g. Scalars and Object types) and -type modifiers (e.g. List and Non-Null types). +wrapped types (e.g. List and Non-Null types). -Type modifiers are used to modify the type presented in the `ofType` field (the -"inner type"). This inner type may recursively be a type modifier. In this way -type modifiers can represent lists, non-nullables, and combinations thereof, -ultimately modifying a named type. +Wrapped types modify the type presented in the field `ofType` (the "inner +type"). This inner type may recursively be a wrapped type, representing lists, +non-nullables, and combinations thereof, ultimately modifying a named type. ### Type Kinds @@ -343,11 +342,11 @@ Fields #### List -Lists represent sequences of values in GraphQL. A List type is a type modifier: +Lists represent sequences of values in GraphQL. A List type is a wrapped type: it wraps another type instance in the `ofType` field, which defines the type of each item in the list. -The modified type in the `ofType` field may itself be a modified type, allowing +The type presented in the `ofType` field may itself be a wrapped type, allowing the representation of Lists of Lists, or Lists of Non-Nulls. Fields @@ -361,13 +360,13 @@ Fields GraphQL types are nullable. The value {null} is a valid response for field type. -A Non-Null type is a type modifier: it wraps another type instance in the +A Non-Null type is a wrapped type: it wraps another type instance in the `ofType` field. Non-null types do not allow {null} as a response, and indicate required inputs for arguments and input object fields. -The modified type in the `ofType` field may itself be a modified List type, -allowing the representation of Non-Null of Lists. However it must not be a -modified Non-Null type to avoid a redundant Non-Null of Non-Null. +The type presented in the `ofType` field may itself be a List wrapped type, +allowing the representation of Non-Null of Lists. However it must not be a +Non-Null wrapped type to avoid a redundant Non-Null of Non-Null. * `kind` must return `__TypeKind.NON_NULL`. * `ofType`: Any type except Non-Null. From 48220ae635d5df2bbd09ee97e1407c991fdd26ba Mon Sep 17 00:00:00 2001 From: Benjie Gillam Date: Tue, 27 Apr 2021 18:54:29 +0100 Subject: [PATCH 3/3] This -> The --- spec/Section 4 -- Introspection.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/Section 4 -- Introspection.md b/spec/Section 4 -- Introspection.md index 0a4bf1a55..4c2f71d6e 100644 --- a/spec/Section 4 -- Introspection.md +++ b/spec/Section 4 -- Introspection.md @@ -230,7 +230,7 @@ types in the system: both named types (e.g. Scalars and Object types) and wrapped types (e.g. List and Non-Null types). Wrapped types modify the type presented in the field `ofType` (the "inner -type"). This inner type may recursively be a wrapped type, representing lists, +type"). The inner type may recursively be a wrapped type, representing lists, non-nullables, and combinations thereof, ultimately modifying a named type. ### Type Kinds