Address review feedback

s/fieldName/memberName

Adds wrapping object around return type of resolveSchemaCoordinate to ensure it's easy to use that result.

Author: leebyron

src/index.d.ts

@@ -181,7 +181,6 @@ export {
   GraphQLScalarSerializer,
   GraphQLScalarValueParser,
   GraphQLScalarLiteralParser,
-  GraphQLSchemaElement,
 } from './type/index';
 
 // Parse and operate on GraphQL language source files.
@@ -462,4 +461,5 @@ export {
   BreakingChange,
   DangerousChange,
   TypedQueryDocumentNode,
+  GraphQLSchemaElement,
 } from './utilities/index';

src/index.js

@@ -168,7 +168,6 @@ export type {
   GraphQLScalarSerializer,
   GraphQLScalarValueParser,
   GraphQLScalarLiteralParser,
-  GraphQLSchemaElement,
 } from './type/index';
 
 // Parse and operate on GraphQL language source files.
@@ -450,4 +449,5 @@ export type {
   BuildSchemaOptions,
   BreakingChange,
   DangerousChange,
+  GraphQLSchemaElement,
 } from './utilities/index';

src/language/__tests__/parser-test.js

@@ -544,7 +544,7 @@ describe('Parser', () => {
           loc: { start: 0, end: 6 },
           value: 'MyType',
         },
-        fieldName: undefined,
+        memberName: undefined,
         argumentName: undefined,
       });
     });
@@ -560,7 +560,7 @@ describe('Parser', () => {
           loc: { start: 0, end: 6 },
           value: 'MyType',
         },
-        fieldName: {
+        memberName: {
           kind: Kind.NAME,
           loc: { start: 7, end: 12 },
           value: 'field',
@@ -589,7 +589,7 @@ describe('Parser', () => {
           loc: { start: 0, end: 6 },
           value: 'MyType',
         },
-        fieldName: {
+        memberName: {
           kind: Kind.NAME,
           loc: { start: 7, end: 12 },
           value: 'field',
@@ -622,7 +622,7 @@ describe('Parser', () => {
           loc: { start: 1, end: 12 },
           value: 'myDirective',
         },
-        fieldName: undefined,
+        memberName: undefined,
         argumentName: undefined,
       });
     });
@@ -638,7 +638,7 @@ describe('Parser', () => {
           loc: { start: 1, end: 12 },
           value: 'myDirective',
         },
-        fieldName: undefined,
+        memberName: undefined,
         argumentName: {
           kind: Kind.NAME,
           loc: { start: 13, end: 16 },

src/language/ast.d.ts

@@ -609,6 +609,6 @@ export interface SchemaCoordinateNode {
   readonly loc?: Location;
   readonly isDirective: boolean;
   readonly name: NameNode;
-  readonly fieldName?: NameNode;
+  readonly memberName?: NameNode;
   readonly argumentName?: NameNode;
 }

src/language/ast.js

@@ -635,6 +635,6 @@ export type SchemaCoordinateNode = {|
   +loc?: Location,
   +isDirective: boolean,
   +name: NameNode,
-  +fieldName?: NameNode,
+  +memberName?: NameNode,
   +argumentName?: NameNode,
 |};

src/language/parser.js

@@ -1371,13 +1371,13 @@ export class Parser {
     const start = this._lexer.token;
     const isDirective = this.expectOptionalToken(TokenKind.AT);
     const name = this.parseName();
-    let fieldName;
+    let memberName;
     if (!isDirective && this.expectOptionalToken(TokenKind.DOT)) {
-      fieldName = this.parseName();
+      memberName = this.parseName();
     }
     let argumentName;
     if (
-      (isDirective || fieldName) &&
+      (isDirective || memberName) &&
       this.expectOptionalToken(TokenKind.PAREN_L)
     ) {
       argumentName = this.parseName();
@@ -1388,7 +1388,7 @@ export class Parser {
       kind: Kind.SCHEMA_COORDINATE,
       isDirective,
       name,
-      fieldName,
+      memberName,
       argumentName,
       loc: this.loc(start),
     };

src/language/printer.js

@@ -305,11 +305,11 @@ const printDocASTReducer: any = {
   // Schema Coordinate
 
   SchemaCoordinate: {
-    leave: ({ isDirective, name, fieldName, argumentName }) =>
+    leave: ({ isDirective, name, memberName, argumentName }) =>
       join([
         isDirective && '@',
         name,
-        wrap('.', fieldName),
+        wrap('.', memberName),
         wrap('(', argumentName, ':)'),
       ]),
   },

src/language/visitor.js

@@ -123,7 +123,7 @@ const QueryDocumentKeys = {
   EnumTypeExtension: ['name', 'directives', 'values'],
   InputObjectTypeExtension: ['name', 'directives', 'fields'],
 
-  SchemaCoordinate: ['name', 'fieldName', 'argumentName'],
+  SchemaCoordinate: ['name', 'memberName', 'argumentName'],
 };
 
 export const BREAK: { ... } = Object.freeze({});