Skip to content

fix(Decimal): parse integers as decimal. #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 6, 2021
Merged

fix(Decimal): parse integers as decimal. #1295

merged 2 commits into from
Jan 6, 2021

Conversation

@zbyte64
Copy link
Contributor

@zbyte64 zbyte64 commented Jan 2, 2021 •
edited
Loading

  • Accept IntNode into decimal type
  • Add test exhibiting failure
  • Enable py38 in tox

@zbyte64 zbyte64 mentioned this pull request Jan 2, 2021
Merged
@ulgens
Copy link
Contributor

ulgens commented Jan 5, 2021

@jkimbo 👋

jkimbo
jkimbo requested changes Jan 5, 2021
View reviewed changes
@zbyte64 zbyte64 changed the title fix(Decimal): parse integers and floats as decimal. fix(Decimal): parse integers as decimal. Jan 6, 2021
@zbyte64 zbyte64 requested a review from jkimbo January 6, 2021 05:50
@jkimbo jkimbo merged commit e5eeb9d into graphql-python:master Jan 6, 2021
@ulgens
Copy link
Contributor

ulgens commented Jan 6, 2021

@jkimbo Would you consider a new release for this?

@jkimbo
Copy link
Member

jkimbo commented Jan 6, 2021

@ulgens sure can do.

@jkimbo
Copy link
Member

jkimbo commented Jan 6, 2021

@ulgens published a new beta release: https://github.com/graphql-python/graphene/releases/tag/v3.0.0b7

Might take a while before it gets through Travis though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkimbo jkimbo jkimbo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zbyte64 @ulgens @jkimbo