From 388b5e2b8a221d9680716a859b1e8a7f5443ff57 Mon Sep 17 00:00:00 2001 From: Charlie Andrews Date: Tue, 13 Jun 2023 19:45:54 +0000 Subject: [PATCH 1/2] Recreate loader if old loader is on incorrect loop --- graphene_sqlalchemy/batching.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/graphene_sqlalchemy/batching.py b/graphene_sqlalchemy/batching.py index a580451..fddf611 100644 --- a/graphene_sqlalchemy/batching.py +++ b/graphene_sqlalchemy/batching.py @@ -137,9 +137,8 @@ def _get_loader(relationship_prop): RELATIONSHIP_LOADERS_CACHE[relationship_prop] = loader return loader - loader = _get_loader(relationship_prop) async def resolve(root, info, **args): - return await loader.load(root) + return await _get_loader(relationship_prop).load(root) return resolve From 9ac645152e02eac519bb07aaa352d557f2b6ec7c Mon Sep 17 00:00:00 2001 From: Cadu Date: Tue, 13 Jun 2023 17:06:06 -0300 Subject: [PATCH 2/2] Lint --- graphene_sqlalchemy/batching.py | 1 - graphene_sqlalchemy/tests/models.py | 1 - 2 files changed, 2 deletions(-) diff --git a/graphene_sqlalchemy/batching.py b/graphene_sqlalchemy/batching.py index fddf611..731d764 100644 --- a/graphene_sqlalchemy/batching.py +++ b/graphene_sqlalchemy/batching.py @@ -137,7 +137,6 @@ def _get_loader(relationship_prop): RELATIONSHIP_LOADERS_CACHE[relationship_prop] = loader return loader - async def resolve(root, info, **args): return await _get_loader(relationship_prop).load(root) diff --git a/graphene_sqlalchemy/tests/models.py b/graphene_sqlalchemy/tests/models.py index b638b5d..45d2379 100644 --- a/graphene_sqlalchemy/tests/models.py +++ b/graphene_sqlalchemy/tests/models.py @@ -26,7 +26,6 @@ from graphene_sqlalchemy.utils import SQL_VERSION_HIGHER_EQUAL_THAN_1_4, SQL_VERSION_HIGHER_EQUAL_THAN_2 # fmt: off -import sqlalchemy if SQL_VERSION_HIGHER_EQUAL_THAN_2: from sqlalchemy.sql.sqltypes import HasExpressionLookup # noqa # isort:skip else: