Skip to content

Conversation

@DoctorJohn
Copy link
Contributor

As discussed in #860 and planned in #705 this PR makes the v3 django choice field enum naming default. It also replaces the DJANGO_CHOICE_FIELD_ENUM_V3_NAMING with a DJANGO_CHOICE_FIELD_ENUM_V2_NAMING setting to re-enable the old naming convention.

@DoctorJohn DoctorJohn changed the title Make v3 django choice field enum naming default Make v3 django choice field enum naming default (in v3) Jun 7, 2020
@ulgens ulgens requested review from jkimbo and ulgens June 7, 2020 15:12
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkimbo jkimbo mentioned this pull request Jun 10, 2020
7 tasks
@jkimbo jkimbo merged commit 17146f9 into graphql-python:v3 Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants