Bugfix: Correct filter types for DjangoFilterConnectionFields #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbyte64
reviewed
Jun 19, 2019
Collaborator
zbyte64
left a comment
zbyte64
left a comment
There was a problem hiding this comment.
Looks good, just have the one question: should we be converting based off the model field instead?
jkimbo
force-pushed
the
bugfix/django-filters-number-types
branch
from
e3fe285 to
53d81ef
Compare
zbyte64
approved these changes
Jun 26, 2019
Merged
sliverc
added a commit
to sliverc/caluma
that referenced
this pull request
Jul 18, 2019
This is an regression of graphql-python/graphene-django#682 but because upstream doesn't support enum for filters it's not an regression for them. Before filter field was converted now the form field is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #678
For Django IntegerFields, Django-filter converts it to a NumberFilter and NumberFilter defines it's Django form field as a DecimalField. Graphene-Django then uses that form field to determine the GraphQL type to use for the filter, so in this case an IntegerField defined on the model gets converted into a Float argument when used as a filter.
This PR changes the logic so that (if it can) it uses the Django model field to determine the corresponding form field rather than Django-filter.
In this PR I've also cleaned up the
test_fieldsfile a bit and added a black compatible config for isort.